Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-autocomplete 'required' validation broken in 1.0.1 #6393

Closed
tecklund opened this issue Dec 18, 2015 · 14 comments
Closed

md-autocomplete 'required' validation broken in 1.0.1 #6393

tecklund opened this issue Dec 18, 2015 · 14 comments
Assignees
@devversion
Labels
P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review type: bug
Milestone
1.1.0

Comments

@tecklund
Copy link

The Floating Label Autocomplete demo is broken in versions 1.0.0, 1.0.1 and HEAD, although it was working in 0.11.4. Leaving the field empty does not cause the form to have the 'required' error.

Other validations (min, max) seem to be working.
@topherfangio
Copy link
Contributor

Related to #6313.

@topherfangio topherfangio added this to the 1.01 milestone Dec 18, 2015
@Nazanin1369
Copy link

@topherfangio Any one working on this?

@bOOm-X
Copy link

bOOm-X commented Dec 21, 2015

It should work if you put required="true"

@tecklund
Copy link
Author

it looks like required="true" does work

@bOOm-X
Copy link

bOOm-X commented Dec 21, 2015

Yes it does !
It is a small bug in the parsing of the required attribute.
I will do a merge request as soon as I can (tomorrow Paris time)

@tecklund
Copy link
Author

Thank you!

@ThomasBurleson ThomasBurleson modified the milestones: 1.0.1, 1.0.2 Jan 5, 2016
@91K00
Copy link

91K00 commented Jan 8, 2016

Ok great! Thanks

@Wykks Wykks mentioned this issue Jan 12, 2016
Closed
@ThomasBurleson ThomasBurleson added P1: urgent Urgent issues that should be addressed in the next minor or patch release. and removed priority: high labels Jan 13, 2016
devversion added a commit to devversion/material that referenced this issue Jan 21, 2016
@devversion
fix(autocomplete): correctly validate required and disabled attri…
dfedf93 
…bute

This issue is nearly the same as angular#6714
Perhaps create a function in the $mdUtils to validate an attribute correctly. Thoughts?

Fixes angular#6415 Fixes angular#6393
devversion added a commit to devversion/material that referenced this issue Jan 21, 2016
@devversion
fix(autocomplete): correctly validate required and disabled attri…
763adf6 
…bute

This issue is nearly the same as angular#6714
Maybe create a function in the `$mdUtils` to validate an attribute correctly. Thoughts?

Fixes angular#6415 Fixes angular#6393
@devversion devversion mentioned this issue Jan 21, 2016
Closed
@manasovdan
Copy link

seems like required="true" makes sense but ng-messages still not working

@devversion devversion mentioned this issue Jan 22, 2016
Closed
devversion added a commit to devversion/material that referenced this issue Jan 22, 2016
@devversion
fix(autocomplete): correctly validate required and disabled attri…
e6c68b4 
…bute

This issue is nearly the same as angular#6714
Maybe create a function in the `$mdUtils` to validate an attribute correctly. Thoughts?

Fixes angular#6415 Fixes angular#6393 Fixes angular#5896
devversion added a commit to devversion/material that referenced this issue Jan 26, 2016
@devversion
fix(autocomplete): correctly validate required and disabled attri…
5cb2785 
…bute

This issue is nearly the same as angular#6714
Maybe create a function in the `$mdUtils` to validate an attribute correctly. Thoughts?

Fixes angular#6415 Fixes angular#6393 Fixes angular#5896
devversion added a commit to devversion/material that referenced this issue Jan 27, 2016
@devversion
fix(autocomplete, select): correctly validate attribute values as boo…
ab5f6c4 
…lean

Fixes angular#6415 Fixes angular#6393 Fixes angular#5896 Fixes angular#6698
@ThomasBurleson ThomasBurleson modified the milestones: 1.0.2, 1.0.5 Jan 28, 2016
devversion added a commit to devversion/material that referenced this issue Feb 3, 2016
@devversion
fix(autocomplete, select): correctly validate attribute values as boo…
6721dbf 
…lean

Fixes angular#6415 Fixes angular#6393 Fixes angular#5896 Fixes angular#6698
@ThomasBurleson ThomasBurleson modified the milestones: 1.0.5, 1.0.6 Feb 4, 2016
devversion added a commit to devversion/material that referenced this issue Feb 8, 2016
@devversion
fix(autocomplete, select, virtualrepeat): correctly validate attribut…
38b20f3 
…e values as boolean

Fixes angular#7063 Fixes angular#6415 Fixes angular#6393 Fixes angular#5896 Fixes angular#6698
devversion added a commit to devversion/material that referenced this issue Feb 8, 2016
@devversion
fix(autocomplete, select, virtualrepeat): correctly validate attribut…
d86f34a 
…e values as boolean

Fixes angular#7063 Fixes angular#6415 Fixes angular#6393 Fixes angular#5896 Fixes angular#6698
@wembernard wembernard mentioned this issue Feb 8, 2016
Closed
devversion added a commit to devversion/material that referenced this issue Feb 8, 2016
@devversion
fix(autocomplete, select, virtualrepeat): correctly validate attribut…
5688de2 
…e values as boolean

Fixes angular#7063 Fixes angular#6415 Fixes angular#6393 Fixes angular#5896 Fixes angular#6698
devversion added a commit to devversion/material that referenced this issue Feb 10, 2016
@devversion
fix(autocomplete, select, virtualrepeat): correctly validate attribut…
c55f909 
…e values as boolean

Fixes angular#7063 Fixes angular#6415 Fixes angular#6393 Fixes angular#5896 Fixes angular#6698
devversion added a commit to devversion/material that referenced this issue Feb 10, 2016
@devversion
fix(autocomplete, select, virtualrepeat): correctly validate attribut…
3c4d106 
…e values as boolean

Fixes angular#7063 Fixes angular#6415 Fixes angular#6393 Fixes angular#5896 Fixes angular#6698 Fixes angular#7105
devversion added a commit to devversion/material that referenced this issue Feb 10, 2016
@devversion
fix(autocomplete, select, virtualrepeat): correctly validate attribut…
5412559 
…e values as boolean

Fixes angular#7063 Fixes angular#6415 Fixes angular#6393 Fixes angular#5896 Fixes angular#6698 Fixes angular#7105
devversion added a commit to devversion/material that referenced this issue Feb 11, 2016
@devversion
fix(autocomplete, select, virtualrepeat): correctly validate attribut…
4b4a226 
…e values as boolean

Fixes angular#5831 Fixes angular#7063 Fixes angular#6415 Fixes angular#6393 Fixes angular#5896 Fixes angular#6698 Fixes angular#7105
devversion added a commit to devversion/material that referenced this issue Feb 12, 2016
@devversion
fix(autocomplete, select, virtualrepeat): correctly validate attribut…
29ad320 
…e values as boolean

Fixes angular#5831 Fixes angular#7063 Fixes angular#6415 Fixes angular#6393 Fixes angular#5896 Fixes angular#6698 Fixes angular#7105
devversion added a commit to devversion/material that referenced this issue Feb 12, 2016
@devversion
fix(autocomplete, select, virtualrepeat): correctly validate attribut…
71cd708 
…e values as boolean

Fixes angular#5831 Fixes angular#7063 Fixes angular#6415 Fixes angular#6393 Fixes angular#5896 Fixes angular#6698 Fixes angular#7105
@devversion devversion added the pr: merge ready This PR is ready for a caretaker to review label Feb 25, 2016
@devversion devversion self-assigned this Feb 25, 2016
@MasterRam
Copy link

i installed bower component "angular-material": "1.0.6"
but i feel the issue #6393 still exist.
image

@devversion
Copy link
Member

@MasterRam The fix has been released in 1.1.0-rc1, not in v1.0.6

@devversion devversion modified the milestones: 1.1.0, 1.0.6 Mar 29, 2016
@kevinlbatchelor
Copy link

+1

@MasterRam
Copy link

Thanks It is working fine....:)
On Apr 3, 2016 6:54 AM, "kevinlbatchelor" notifications@github.com wrote:

+1

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@jonathanread
Copy link

jonathanread commented Jan 3, 2017 •
edited
Loading

I am using angular material 1.1.1. I am not able to get my required autocomplete to work. The form does not submit, to the required attribute is working but the ng-message never shows.
Gist
I have tried all above suggestions ...

So after reviewing #1780 and @91K00 code it appears that the required only 'works' (meaning displays) when the <md-autocomplete> is wrapped with <md-input-container>, this does not match the documentation. I am also not a huge fan of the moving floating label. Can we fix the required to display when NOT using the <md-input-container> wrapper. Thanks

@Karasuni
Copy link

Karasuni commented Feb 1, 2017

I'm observing the same exact issue as @jonathanread : In 1.1.1 the md-autocomplete does not work using 'md-required' or 'required' tags. This is inconsistent with other elements and the documentation.

@Karasuni Karasuni mentioned this issue Feb 1, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
13 participants
@topherfangio @ThomasBurleson @bOOm-X @manasovdan @jonathanread @tecklund @devversion @kevinlbatchelor @Nazanin1369 @91K00 @MasterRam @Karasuni and others