-
Notifications
You must be signed in to change notification settings - Fork 3.4k
mdToast (docs): examples don't align with Material Spec #6607
Comments
That's right, so perhaps we should only add a button for |
Yes, I think an UNDO or RETRY button in the examples would better align with the spec. |
Yes, sounds good ;) then we should simply add a highlight color. |
Using For the custom action, there is a style that is overriding putting |
The Accent Color looks much more handsome as the primary highlight. But I think the Specs use the Accent Color too? |
It does look like the spec prefers the accent color for the snackbar action highlight. It seems like using |
@devversion Sorry for the confusion in our discussion; yes, as far as I can tell, it should use the accent color, not the primary color. |
…n demo with specs - Add `highlightClass` method to toast (very useful! - and won't break anything) - Improved the docs design for the possible methods for the #simple method. - Changed demo to align with specs, No Dismiss buttons. - Highlight Color should use by default the accent color. Fixes angular#6607
…n demo with specs - Add `highlightClass` method to toast (very useful! - and won't break anything) - Improved the docs design for the possible methods for the #simple method. - Changed demo to align with specs, No Dismiss buttons. - Highlight Color should use by default the accent color. Fixes angular#6607
…n demo with specs - Add `highlightClass` method to toast (very useful! - and won't break anything) - Improved the docs design for the possible methods for the #simple method. - Changed demo to align with specs, No Dismiss buttons. - Highlight Color should use by default the accent color. Fixes angular#6607
…n demo with specs BREAKING CHANGE: Toasts now use accent color by default for a highlighted action button. - Add `highlightClass` method to toast (very useful! - and won't break anything) - Improved the docs design for the possible methods for the #simple method. - Changed demo to align with specs, No Dismiss buttons. - Highlight Color should use by default the accent color. Fixes angular#6607
Currently the docs show an 'OK' button and a 'Close' button in the two snackbar (toast) examples (Show With Action, Show Custom).
Based on the spec having this kind of a 'Dismiss', 'OK', 'Close' button in a snackbar is a "Don't".
The docs should not show examples of things that go against the spec as it creates confusion with users.
The text was updated successfully, but these errors were encountered: