Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

mdToast (docs): examples don't align with Material Spec #6607

Closed
Splaktar opened this issue Jan 9, 2016 · 7 comments
Closed

mdToast (docs): examples don't align with Material Spec #6607

Splaktar opened this issue Jan 9, 2016 · 7 comments
Labels
P3: important Important issues that really should be fixed when possible. type: docs

Comments

@Splaktar
Copy link
Member

Splaktar commented Jan 9, 2016

Currently the docs show an 'OK' button and a 'Close' button in the two snackbar (toast) examples (Show With Action, Show Custom).

Based on the spec having this kind of a 'Dismiss', 'OK', 'Close' button in a snackbar is a "Don't".

The docs should not show examples of things that go against the spec as it creates confusion with users.

@devversion
Copy link
Member

That's right, so perhaps we should only add a button for UNDO, which represents the possibility of placing a button in there. Thoughts?

@Splaktar
Copy link
Member Author

Splaktar commented Jan 9, 2016

Yes, I think an UNDO or RETRY button in the examples would better align with the spec.

@devversion
Copy link
Member

Yes, sounds good ;) then we should simply add a highlight color.
And how can we get that green color? is it also in the palette?

@Splaktar
Copy link
Member Author

Splaktar commented Jan 9, 2016

Using .highlightAction(true) on the simple toast builder gives the button md-primary. Should this be accent instead?

For the custom action, there is a style that is overriding putting md-accent on the button in the template and making the button white. I had to add a custom style to use the accent color over this white style.

http://codepen.io/Splaktar/pen/jWmQad

@devversion
Copy link
Member

The Accent Color looks much more handsome as the primary highlight. But I think the Specs use the Accent Color too?

@Splaktar
Copy link
Member Author

Splaktar commented Jan 9, 2016

It does look like the spec prefers the accent color for the snackbar action highlight. It seems like using md-warn, and md-primary on the button should be allowed as well, but not the default.

@ThomasBurleson ThomasBurleson added Q1 P3: important Important issues that really should be fixed when possible. and removed Q1 labels Jan 13, 2016
@ThomasBurleson ThomasBurleson modified the milestone: Backlog Jan 13, 2016
@topherfangio
Copy link
Contributor

@devversion Sorry for the confusion in our discussion; yes, as far as I can tell, it should use the accent color, not the primary color.

devversion added a commit to devversion/material that referenced this issue Feb 23, 2016
…n demo with specs

- Add `highlightClass` method to toast (very useful! - and won't break anything)
- Improved the docs design for the possible methods for the #simple method.
- Changed demo to align with specs, No Dismiss buttons.
- Highlight Color should use by default the accent color.

Fixes angular#6607
devversion added a commit to devversion/material that referenced this issue Feb 23, 2016
…n demo with specs

- Add `highlightClass` method to toast (very useful! - and won't break anything)
- Improved the docs design for the possible methods for the #simple method.
- Changed demo to align with specs, No Dismiss buttons.
- Highlight Color should use by default the accent color.

Fixes angular#6607
devversion added a commit to devversion/material that referenced this issue Feb 23, 2016
…n demo with specs

- Add `highlightClass` method to toast (very useful! - and won't break anything)
- Improved the docs design for the possible methods for the #simple method.
- Changed demo to align with specs, No Dismiss buttons.
- Highlight Color should use by default the accent color.

Fixes angular#6607
devversion added a commit to devversion/material that referenced this issue Feb 23, 2016
…n demo with specs

BREAKING CHANGE: Toasts now use accent color by default for a highlighted action button.

- Add `highlightClass` method to toast (very useful! - and won't break anything)
- Improved the docs design for the possible methods for the #simple method.
- Changed demo to align with specs, No Dismiss buttons.
- Highlight Color should use by default the accent color.

Fixes angular#6607
@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3: important Important issues that really should be fixed when possible. type: docs
Projects
None yet
Development

No branches or pull requests

5 participants