Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fabSpeedDial - 'FabController' name is not namespaced #6881

Closed
zzebastien opened this issue Jan 27, 2016 · 3 comments
Closed

fabSpeedDial - 'FabController' name is not namespaced #6881

zzebastien opened this issue Jan 27, 2016 · 3 comments
Assignees
Labels
P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review
Milestone

Comments

@zzebastien
Copy link

The FabController is not namespaced with 'Md'.

In our application we already have a controller named 'FabController', and it overrides the Angular Material FabController.
File: fabController.js

angular.module('material.components.fabShared', ['material.core'])
    .controller('FabController', FabController);

So all the logic of FAB Speed Dial does not work in our application. Of course we can rename our controller, but still you should name it 'MdFabController' instead.

- Please rename FabControler to MdFabController

Other controllers within Angular Material are namespaced with 'Md' so I assume you do not have a pre-build check to verify that all controllers are correctly namespaced.

Example of a controller with a correct name: chipsController.js

angular
    .module('material.components.chips')
    .controller('MdChipsCtrl', MdChipsCtrl);

The menuItemController have the same problem: menuItemController.js

'MenuItemController' should be 'MdMenuItemController'

Angular Material: 1.0.3

Thanks !
Keep up the good work team :)

@Yann77
Copy link

Yann77 commented Jan 27, 2016

+1

@LPCmedia
Copy link

+2

@ThomasBurleson ThomasBurleson added the P1: urgent Urgent issues that should be addressed in the next minor or patch release. label Jan 28, 2016
@ThomasBurleson ThomasBurleson added this to the 1.0.4 milestone Jan 28, 2016
@ThomasBurleson
Copy link
Contributor

Attn @topherfangio - #breakingChange

@ThomasBurleson ThomasBurleson modified the milestones: 1.0.5, 1.0.4 Jan 28, 2016
topherfangio added a commit to profoundry-us/material that referenced this issue Jan 29, 2016
The FabController was not properly namespaced for Material Design.
Fix by adding `Md` to the beginning to ensure we do not override
users controllers.

Fixes angular#6881.
@topherfangio topherfangio added the pr: merge ready This PR is ready for a caretaker to review label Jan 29, 2016
ErinCoughlan pushed a commit to ErinCoughlan/material that referenced this issue Feb 9, 2016
The FabController was not properly namespaced for Material Design.
Fix by adding `Md` to the beginning to ensure we do not override
users controllers.

Fixes angular#6881. Closes angular#6919.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

No branches or pull requests

5 participants