This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fabSpeedDial - 'FabController' name is not namespaced #6881
Labels
P1: urgent
Urgent issues that should be addressed in the next minor or patch release.
pr: merge ready
This PR is ready for a caretaker to review
Milestone
The FabController is not namespaced with 'Md'.
In our application we already have a controller named 'FabController', and it overrides the Angular Material FabController.
File: fabController.js
So all the logic of FAB Speed Dial does not work in our application. Of course we can rename our controller, but still you should name it 'MdFabController' instead.
- Please rename FabControler to MdFabController
Other controllers within Angular Material are namespaced with 'Md' so I assume you do not have a pre-build check to verify that all controllers are correctly namespaced.
Example of a controller with a correct name: chipsController.js
The menuItemController have the same problem: menuItemController.js
'MenuItemController' should be 'MdMenuItemController'
Angular Material: 1.0.3
Thanks !
Keep up the good work team :)
The text was updated successfully, but these errors were encountered: