Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-fab-toolbar: ng-click not working with IE 11 on md-fab-actions #7012

Closed
alexitooi opened this issue Feb 3, 2016 · 12 comments
Closed

md-fab-toolbar: ng-click not working with IE 11 on md-fab-actions #7012

alexitooi opened this issue Feb 3, 2016 · 12 comments
Labels
browser: IE This issue is specific to Internet Explorer P1: urgent Urgent issues that should be addressed in the next minor or patch release.

Comments

@alexitooi
Copy link

Codepen: http://codepen.io/anon/pen/mVGPqb?editors=1111
Angular 1.3.19
Angular Material: 1.0.4

With chrome a click on the md-button inside the md-fab-actions is working. On IE11 the click is not working (see console log in codepen...)

Any workaround possible?

Cheers,
Alex

@svmmym
Copy link

svmmym commented Feb 4, 2016

+1

@ThomasBurleson ThomasBurleson added browser: IE This issue is specific to Internet Explorer P1: urgent Urgent issues that should be addressed in the next minor or patch release. labels Feb 4, 2016
@ThomasBurleson ThomasBurleson added this to the Backlog milestone Feb 4, 2016
@topherfangio
Copy link
Contributor

Is there a reason you are putting the ng-click on the nested <div>? Try putting it directly on the md-button instead; this seems to work.

@svmmym
Copy link

svmmym commented Feb 11, 2016

this didn't solve the problem for me. if i put the ng-click on the md-button in the codepen above, the ng-click is still not working on IE11.

@alexitooi
Copy link
Author

@topherfangio neither it is working for me with ng-click on the md-button with IE11

@topherfangio
Copy link
Contributor

I must admit, I am a bit confused as this did work for me on IE11 on Windows 10 when I edited the supplied Codepen and moved the ng-click.

@samesame @alexitooi Can you two provide a bit more information about what versions of IE/Windows you are using so we can track this down? Is this perhaps touch-related or is it actually desktop clicks?

@alexitooi
Copy link
Author

Hi @topherfangio , to clarify Win10 IE11 click on button working, on Win7 IE11 click not working ;) (Version 11.0.9600.17420)

@topherfangio
Copy link
Contributor

@alexitooi Bah! Good to know that the same browser (IE11) doesn't work the same on different versions of the same OS. We'll look into it; just need to find someone running Win7 so we can debug :-)

@alexitooi
Copy link
Author

@david-gang
Copy link
Contributor

I also have this problem. @topherfangio just to complement the knowledge about the ie versions. Their versions are different. https://en.wikipedia.org/wiki/Internet_Explorer_11

In windows 7 the latest version is 11.0.9600.17843[ and in windows 10 the latest version is 11.0.10240.16384 so technically they are different :-)

The problem is also visible in the toolbar demo: https://material.angularjs.org/latest/demo/fabToolbar
When the fab is opened, and you press a button. In other browsers there is a small white circle while here in ie there is no white circle.

@rhumbus
Copy link

rhumbus commented Apr 10, 2016

The root of the problem here stems in the particular CSS propery that is added to the actions toolbar when open.

If you look in fabToolbar.js, line 138:
toolbarElement.style.pointerEvents = 'initial';
The md-toolbar element is targeted to receive the css property pointer-events with the value initial upon opening the fab-toolbar. It seems that Explorer (the above mentioned versions) doesn't recognize the value initial, at least not via javascript, and therefore not altering that property - so the property remains as defined in the closed state of the fab-toolbar, which is none. This causes the md-toolbar to block pointer events down to its children.

Furthermore, as pointed to me by david-gang, the value 'initial' is not part of the specs for 'pointer-events'.

Changing the value to auto solves the problem:
toolbarElement.style.pointerEvents = 'auto';

@topherfangio
Copy link
Contributor

@rhumbus Thanks for taking the time to track this down some more! Can you do a quick test and see if changing it to auto works on the other browsers as well? For some reason, I was thinking I had auto and switched it to initial, but that was so long ago that I don't remember.

If that works, would be be willing to submit a PR so that we can get it merged/fixed?

david-gang added a commit to david-gang/material that referenced this issue Apr 17, 2016
The inherit attribute did not work well in ie11 on windows7. The buttons of the toolbar could not be opened.  The fix was tested in chrome, FF, IE11, Edge and Safari

Closes angular#7012
@alexitooi
Copy link
Author

thx @david-gang @topherfangio 👍

david-gang added a commit to david-gang/material that referenced this issue Jun 5, 2016
The inherit attribute did not work well in ie11 on windows7. The buttons of the toolbar could not be opened.  The fix was tested in chrome, FF, IE11, Edge and Safari

Closes angular#7012
@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser: IE This issue is specific to Internet Explorer P1: urgent Urgent issues that should be addressed in the next minor or patch release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants