Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Gesture drag on md-list-item prevents list from scrolling on iOS #7311

Closed
gustavohenke opened this issue Feb 26, 2016 · 5 comments
Closed

Gesture drag on md-list-item prevents list from scrolling on iOS #7311

gustavohenke opened this issue Feb 26, 2016 · 5 comments
Assignees
@devversion
Labels
os: iOS This issue is specific to iOS P5: nice to have These issues will not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review resolution: fixed
Milestone
1.1.0

Comments

@gustavohenke
Copy link

Hey there,
I have built a custom directive for achieving the Dismiss gesture, as documented in the Material Design spec.

The directive registers a drag gesture with $mdGesture in the element, currently an <md-list-item>:

Because of the registered drag gesture, I can't scroll this list in my iPad 2 (I don't have other iOS devices to test this). This behavior can be observed in Safari, Firefox and Chrome for iOS.
@devversion
Copy link
Member

This won't be related to the actual md-list component, it may relate to your implementation of the $mdGesture service in your directive. I can take a look, if you share a few code snippets or maybe a demo.

@devversion devversion added the needs: demo A CodePen demo or GitHub repository is needed to demonstrate the reproduction of the issue label Feb 26, 2016
@gustavohenke
Copy link
Author

@devversion there you go: http://codepen.io/gustavohenke/pen/grOrWq

Open in an iOS device.

@devversion devversion added needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community os: iOS This issue is specific to iOS and removed needs: demo A CodePen demo or GitHub repository is needed to demonstrate the reproduction of the issue labels Feb 27, 2016
@gpopovic
Copy link

Nice job man !! Hopefully this gets into library

@topherfangio topherfangio added the P4: minor Minor issues. May not be fixed without community contributions. label Mar 24, 2016
@topherfangio topherfangio added P5: nice to have These issues will not be fixed without community contributions. and removed P4: minor Minor issues. May not be fixed without community contributions. labels Mar 24, 2016
@code-tree code-tree mentioned this issue Apr 2, 2016
Closed
@devversion devversion mentioned this issue Apr 2, 2016
Closed
devversion added a commit to devversion/material that referenced this issue Apr 2, 2016
@devversion
fix(gestures): detect touch action and provide polyfill.
1ec7cf8 
* On non-android browsers, touchmove events were cancelled and native scroll was disabled as well.
* touchAction is supported by the most modern-browsers and drops the cancellation of the touchmove event
* If touchAction is not supported, then we're able to use the polyfill (cancelling the touchMove event)

Fixes angular#7311.
@devversion devversion mentioned this issue Apr 2, 2016
Closed
@devversion
Copy link
Member

@gustavohenke Just wanted to let you know, this issue issue is now in progress.

@devversion devversion added the pr: merge ready This PR is ready for a caretaker to review label Apr 2, 2016
devversion added a commit to devversion/material that referenced this issue Apr 4, 2016
@devversion
fix(gestures): detect touch action and provide polyfill.
eff6064 
* On non-android browsers, touchmove events were cancelled and native scroll was disabled as well.
* touchAction is supported by the most modern-browsers and drops the cancellation of the touchmove event
* If touchAction is not supported, then we're able to use the polyfill (cancelling the touchMove event)

Fixes angular#7311.
@ThomasBurleson ThomasBurleson modified the milestone: Backlog Apr 20, 2016
@ThomasBurleson ThomasBurleson modified the milestones: - Backlog, Deprecated May 26, 2016
@devversion devversion modified the milestones: - Backlog, Deprecated May 27, 2016
devversion added a commit to devversion/material that referenced this issue Jun 2, 2016
@devversion
fix(gestures): detect touch action and provide polyfill.
44b9a20 
* On non-android browsers, touchmove events were cancelled and native scroll was disabled as well.
* touchAction is supported by the most modern-browsers and drops the cancellation of the touchmove event
* If touchAction is not supported, then we're able to use the polyfill (cancelling the touchMove event)

Fixes angular#7311.
devversion added a commit to devversion/material that referenced this issue Jun 4, 2016
@devversion
fix(gestures): detect touch action and provide polyfill.
5452394 
* On non-android browsers, touchmove events were cancelled and native scroll was disabled as well.
* touchAction is supported by the most modern-browsers and drops the cancellation of the touchmove event
* If touchAction is not supported, then we're able to use the polyfill (cancelling the touchMove event)

Fixes angular#7311.
@Vercryger
Copy link

Vercryger commented Nov 27, 2016 •
edited
Loading

@gustavohenke Did it work? @ThomasBurleson, @devversion I still having the same issue on Chrome.

@Splaktar Splaktar modified the milestones: - Backlog, 1.1.0 Mar 3, 2018
@Splaktar Splaktar removed the needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community label Mar 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
os: iOS This issue is specific to iOS P5: nice to have These issues will not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review resolution: fixed
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
7 participants
@topherfangio @ThomasBurleson @gustavohenke @gpopovic @Splaktar @Vercryger @devversion