Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Bi-di issues with demos #7399

Closed
ThomasBurleson opened this issue Mar 3, 2016 · 5 comments
Closed

Bi-di issues with demos #7399

ThomasBurleson opened this issue Mar 3, 2016 · 5 comments
Assignees
@EladBezalel
Labels
i18n: bi-directional This issue is related to internationalization and right to left languages P0: critical Critical issues that must be addressed immediately. pr: merge ready This PR is ready for a caretaker to review ui: CSS
Milestone
1.0.7

Comments

@ThomasBurleson
Copy link
Contributor

After the commits for improved Bi-Directional support, the following demos still need work:

screen shot 2016-03-02 at 8 52 12 am

screen shot 2016-03-02 at 8 52 30 am
@ThomasBurleson ThomasBurleson added ui: CSS i18n: bi-directional This issue is related to internationalization and right to left languages labels Mar 3, 2016
@ThomasBurleson ThomasBurleson added this to the 1.0.7 milestone Mar 3, 2016
@EladBezalel
Copy link
Member

@ThomasBurleson @devversion as my native language is RTL and i'm really close to this issue do you mind if i'd do it?

@devversion devversion assigned EladBezalel and unassigned devversion Mar 3, 2016
@devversion
Copy link
Member

@EladBezalel Sure, enjoy :)

@ThomasBurleson ThomasBurleson added the P0: critical Critical issues that must be addressed immediately. label Mar 4, 2016
@ThomasBurleson
Copy link
Contributor Author

@EladBezalel - Thanks for volunteering. 👍

I was hesitant to overload you. 😨

@EladBezalel
Copy link
Member

image

@EladBezalel
Copy link
Member

all those are related to rtl-prop mixin which doesn't 'disables' the ltr property when in rtl mode

EladBezalel added a commit that referenced this issue Mar 4, 2016
@EladBezalel
fix(bidi-demos): fixed broken demos
91ddc82 
- fixed `rtl-prop` mixin to override `ltr` property when applied
- fixed checkbox demos
- fixed datepicker triangle alignment
- fixed divider demos
- fixed inset divider in list
- fixed tooltip demos

fixes #7399
@EladBezalel EladBezalel mentioned this issue Mar 4, 2016
Closed
@EladBezalel EladBezalel added the pr: merge ready This PR is ready for a caretaker to review label Mar 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EladBezalel EladBezalel

Labels
i18n: bi-directional This issue is related to internationalization and right to left languages P0: critical Critical issues that must be addressed immediately. pr: merge ready This PR is ready for a caretaker to review ui: CSS
Projects
None yet
Milestone
1.0.7
Development

Successfully merging a pull request may close this issue.

fix(bidi-demos): fixed broken demos angular/material
3 participants
@ThomasBurleson @devversion @EladBezalel