Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Different ng-message size with ng-show and ng-if #7596

Closed
leolozes opened this issue Mar 16, 2016 · 6 comments
Closed

Different ng-message size with ng-show and ng-if #7596

leolozes opened this issue Mar 16, 2016 · 6 comments
Assignees
Labels
has: Pull Request A PR has been created to address this issue P1: urgent Urgent issues that should be addressed in the next minor or patch release.

Comments

@leolozes
Copy link

As you can see in this codepen, the ng-message font size varies depending on whether the input is defined with a ng-show or ng-if attribute.

It seems that the ng-message div is only generated with the md-input-message-animation class when ng-show is used.

@topherfangio topherfangio self-assigned this Mar 16, 2016
@topherfangio topherfangio added the P1: urgent Urgent issues that should be addressed in the next minor or patch release. label Mar 16, 2016
@gpopovic
Copy link

Might be related to my issue, #7477

@houmark
Copy link

houmark commented Mar 16, 2016

I've also noticed this issue. Hoping for a quick fix as all our validations are now looking very chunky and large.

@gpopovic
Copy link

I'm using this nasty hack..to force it to look as similar to other ng-messages as possible
But this will not fix padding...and animation

md-input-container.md-default-theme .md-input-messages-animation, md-input-container .md-input-messages-animation, md-input-container.md-default-theme .md-input-message-animation, md-input-container .md-input-message-animation {
    font-size: 12px;
}

@houmark
Copy link

houmark commented Mar 16, 2016

@gpopovic yes, but you'll also need the line-height and the animation CSS to make it the same as intended. Hopefully this can be added so it's the same for both ng-if and ng-show.

@topherfangio
Copy link
Contributor

We're reworking a few things with the input/message animations and I have a note to fix this exact issue (it's causing some other problems as well). We'll try to get this fixed soon.

@topherfangio topherfangio added this to the 1.1.1 milestone Mar 17, 2016
@topherfangio topherfangio modified the milestones: 1.3.0, 1.1.1 Apr 18, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.3.0, Backlog Apr 20, 2016
@leolozes
Copy link
Author

As you can see in this codepen, when using ng-messages with md-autocomplete, the font size is also wrong, no matter if you use ng-show or ng-if. You can also see it in the autocomplete demo.

devversion added a commit to devversion/material that referenced this issue May 9, 2016
* Currently ngMessage directives inside of an input-container, which are loaded / transcluded dynamically, didn't get initialized properly.
  The animation was not working. As well as the auto-hide didn't work properly.

Fixes angular#7477. Fixes angular#7596.
devversion added a commit to devversion/material that referenced this issue May 9, 2016
* Currently ngMessage directives inside of an input-container, which are loaded / transcluded dynamically, didn't get initialized properly.
  The animation was not working. As well as the auto-hide didn't work properly.

Fixes angular#7477. Fixes angular#7596.
@devversion devversion assigned devversion and unassigned topherfangio May 9, 2016
@devversion devversion added the has: Pull Request A PR has been created to address this issue label May 9, 2016
devversion added a commit to devversion/material that referenced this issue May 18, 2016
* Currently ngMessage directives inside of an input-container, which are loaded / transcluded dynamically, didn't get initialized properly.
  The animation was not working. As well as the auto-hide didn't work properly.

Fixes angular#7477. Fixes angular#7596. Fixes angular#6810. Fixes angular#7823
devversion added a commit to devversion/material that referenced this issue May 18, 2016
* Currently ngMessage directives inside of an input-container, which are loaded / transcluded dynamically, didn't get initialized properly.
  The animation was not working. As well as the auto-hide didn't work properly.

Fixes angular#7477. Fixes angular#7596. Fixes angular#6810. Fixes angular#7823
@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has: Pull Request A PR has been created to address this issue P1: urgent Urgent issues that should be addressed in the next minor or patch release.
Projects
None yet
Development

No branches or pull requests

7 participants