Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

mdSelect: flickering with ngMessages - regression #7636

Closed
montgomery1944 opened this issue Mar 18, 2016 · 1 comment
Closed

mdSelect: flickering with ngMessages - regression #7636

montgomery1944 opened this issue Mar 18, 2016 · 1 comment
Labels
P4: minor Minor issues. May not be fixed without community contributions. type: bug

Comments

@montgomery1944
Copy link
Contributor

mdSelect error message provided by ngMessages flickers when opening the select pop up on Firefox and Chrome on Linux, other browsers weren't tested.

Demo can be found at http://codepen.io/anon/pen/grmWOe.

Steps to reproduce:

  1. Open select.
    Expected result: "required" message should be not visible before select closes without the selection.
    Current result: "required" message is visible in background, when the select is opened.

This issue was already fixed once in #5879, but those changes were removed in dc8f388. After that, fix for this issue was added in different form in 8d4e7c2, but I don't think that it works properly.

Tested with jQuery 2.2.2, Angular 1.5.2 and Angular Material 1.1.0-rc1.
@topherfangio topherfangio self-assigned this Mar 18, 2016
@topherfangio topherfangio added the P4: minor Minor issues. May not be fixed without community contributions. label Mar 18, 2016
@topherfangio topherfangio added this to the Backlog milestone Mar 18, 2016
@montgomery1944 montgomery1944 mentioned this issue Mar 19, 2016
Closed
@montgomery1944
Copy link
Contributor Author

@topherfangio, I've created a pull request to fix this issue.

ThomasBurleson pushed a commit that referenced this issue Apr 1, 2016
@montgomery1944 @ThomasBurleson
fix(mdSelect): fix flickering of ngMessages on mdSelect opening
f21c4fa 
To properly prevent ngMessages from showing up on select opening,
we have to stop blur event propagation to ngModel listener.
To be close to mdInput behaviour, we do it only, when mdSelect was opened.

closes #7636

Closes #7646
ThomasBurleson pushed a commit that referenced this issue Apr 1, 2016
@montgomery1944 @ThomasBurleson
fix(mdSelect): fix flickering of ngMessages on mdSelect opening
b54f7ed 
To properly prevent ngMessages from showing up on select opening,
we have to stop blur event propagation to ngModel listener.
To be close to mdInput behaviour, we do it only, when mdSelect was opened.

closes #7636

Closes #7646
gmoothart pushed a commit to gmoothart/material that referenced this issue Apr 5, 2016
@montgomery1944 @gmoothart
fix(mdSelect): fix flickering of ngMessages on mdSelect opening
a9fd721 
To properly prevent ngMessages from showing up on select opening,
we have to stop blur event propagation to ngModel listener.
To be close to mdInput behaviour, we do it only, when mdSelect was opened.

closes angular#7636

Closes angular#7646
@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P4: minor Minor issues. May not be fixed without community contributions. type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(mdSelect): fix flickering of ngMessages on mdSelect opening
3 participants
@topherfangio @Splaktar @montgomery1944