Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-menu offset not calculating correctly #8080

Closed
tspayne87 opened this issue Apr 16, 2016 · 2 comments
Closed

md-menu offset not calculating correctly #8080

tspayne87 opened this issue Apr 16, 2016 · 2 comments
Assignees
Labels
has: Pull Request A PR has been created to address this issue

Comments

@tspayne87
Copy link

When you open a menu and you do not have a ng-click before the md-menu-contents tag it will get the first ng-click that may exist within the menu itself. I was using data-ng-click to open my menu which is not being picked up by the init function. I have a fix for this and its adding in the data-ng-click into the querySelector, an example is

Current:
triggerElement = $element[0].querySelector('[ng-click],[ng-mouseenter]');

Change To:
triggerElement = $element[0].querySelector('[data-ng-click],[ng-click],[data-ng-mouseenter],[ng-mouseenter]');

this is all within the init function in the MenuController. I have tested this within my project and it seems to of fixed the issue for me. I hope this helps.

@ThomasBurleson ThomasBurleson modified the milestone: Backlog Apr 20, 2016
@topherfangio
Copy link
Contributor

@devversion I know you are working on a PR to assist in difference between ng-click, data-ng-click, x-ng-click, etc. Will this be fixed as well, or should we just update the querySelector as described above?

@devversion
Copy link
Member

@topherfangio Yea, this will be fixed by my PR.

@devversion devversion added the has: Pull Request A PR has been created to address this issue label Apr 22, 2016
devversion added a commit to devversion/material that referenced this issue Apr 22, 2016
The service is containing the following features:
* Check for an element, to have the specified attribute, including the prefixes
* Generate an attribute selector for the specified attribute
* Build a list of all prefixed attributes

Fixes angular#8080. Closes angular#8121
devversion added a commit to devversion/material that referenced this issue Apr 22, 2016
The service is containing the following features:
* Check for an element, to have the specified attribute, including the prefixes
* Generate an attribute selector for the specified attribute
* Build a list of all prefixed attributes

Fixes angular#8080. Closes angular#8121
@ThomasBurleson ThomasBurleson modified the milestones: - Backlog, Deprecated May 26, 2016
@devversion devversion modified the milestones: - Backlog, Deprecated May 27, 2016
devversion added a commit to devversion/material that referenced this issue May 27, 2016
The service is containing the following features:
* Check for an element, to have the specified attribute, including the prefixes
* Generate an attribute selector for the specified attribute
* Build a list of all prefixed attributes

Fixes angular#8080. Closes angular#8121
devversion added a commit to devversion/material that referenced this issue May 27, 2016
The service is containing the following features:
* Check for an element, to have the specified attribute, including the prefixes
* Generate an attribute selector for the specified attribute
* Build a list of all prefixed attributes

Fixes angular#3258. Fixes angular#8080. Closes angular#8121
devversion added a commit to devversion/material that referenced this issue Jun 2, 2016
The service is containing the following features:
* Check for an element, to have the specified attribute, including the prefixes
* Generate an attribute selector for the specified attribute
* Build a list of all prefixed attributes

Fixes angular#3258. Fixes angular#8080. Closes angular#8121
@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has: Pull Request A PR has been created to address this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants