Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Transitions for content changes (ie. Tab content) #811

Closed
robertmesserle opened this issue Dec 1, 2014 · 3 comments
Closed

Transitions for content changes (ie. Tab content) #811

robertmesserle opened this issue Dec 1, 2014 · 3 comments
Assignees
Milestone

Comments

@robertmesserle
Copy link
Contributor

When clicking through tabbed content, there are transitions for which tab is selected:
the inkbar slides and the clicked tab ripples.

No transitions are provided, however, for the changing tab content. While this can be added by the user, a default transition should be provided out-of-the-box... but only for tabs with 'managed' content (aka internal content).

External content is not managed by the the <md-tabs/> directive(s).

@ThomasBurleson ThomasBurleson added this to the 0.7.0-rc1 milestone Dec 2, 2014
@ThomasBurleson
Copy link
Contributor

This could be easily solved using a role-based CSS selector for the tabPanel:

[role="tabpanel"] {
    transition: all cubic-bezier(0.25, 0.46, 0.45, 0.94) 0.5s;
    position: absolute; 
}
[role="tabpanel"].ng-enter, [role="tabpanel"].ng-leave.ng-leave-active  {

}

If developers do not want an tab content transition, then a role-based override is easy:

[role="tabpanel"] {
    transition: none;
}

@marcysutton
Copy link
Contributor

👍 👍 👍

@ThomasBurleson
Copy link
Contributor

Related to (will fix) #717

robertmesserle added a commit that referenced this issue Dec 18, 2014
By default, now tab content will animate in from whichever direction the
ink-bar is moving.  These animations can be overridden through the
following classes:

When a tab is selected, the following classes are added in order:
1. `md-transition-rtl`: flags the animation as right-to-left
2. `ng-animate`: added at the start of all animations
3. `ng-hide-remove`
4. `ng-hide-remove-active`

When a tab is deselected, the following classes are added in order:
1. `md-transition-rtl`: flags the animation as right-to-left
2. `ng-animate`: added at the start of all animations
3. `ng-hide-add`
4. `ng-hide-add-active`

Closes #717.
Closes #811.
robertmesserle added a commit that referenced this issue Dec 19, 2014
By default, now tab content will animate in from whichever direction the
ink-bar is moving.  These animations can be overridden through the
following classes:

When a tab is selected, the following classes are added in order:
1. `md-transition-rtl`: flags the animation as right-to-left
2. `ng-animate`: added at the start of all animations
3. `ng-hide-remove`
4. `ng-hide-remove-active`

When a tab is deselected, the following classes are added in order:
1. `md-transition-rtl`: flags the animation as right-to-left
2. `ng-animate`: added at the start of all animations
3. `ng-hide-add`
4. `ng-hide-add-active`

Closes #717.
Closes #811.
robertmesserle added a commit that referenced this issue Dec 19, 2014
By default, now tab content will animate in from whichever direction the
ink-bar is moving.  These animations can be overridden through the
following classes:

When a tab is selected, the following classes are added in order:
1. `md-transition-rtl`: flags the animation as right-to-left
2. `ng-animate`: added at the start of all animations
3. `ng-hide-remove`
4. `ng-hide-remove-active`

When a tab is deselected, the following classes are added in order:
1. `md-transition-rtl`: flags the animation as right-to-left
2. `ng-animate`: added at the start of all animations
3. `ng-hide-add`
4. `ng-hide-add-active`

Closes #717.
Closes #811.
@ajoslin ajoslin added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Dec 19, 2014
robertmesserle added a commit that referenced this issue Dec 20, 2014
By default, now tab content will animate in from whichever direction the
ink-bar is moving.  These animations can be overridden through the
following classes:

When a tab is selected, the following classes are added in order:
1. `md-transition-rtl`: flags the animation as right-to-left
2. `ng-animate`: added at the start of all animations
3. `ng-hide-remove`
4. `ng-hide-remove-active`

When a tab is deselected, the following classes are added in order:
1. `md-transition-rtl`: flags the animation as right-to-left
2. `ng-animate`: added at the start of all animations
3. `ng-hide-add`
4. `ng-hide-add-active`

Closes #717.
Closes #811.

refactor(tabs): removes unnecessary check
robertmesserle added a commit that referenced this issue Jan 8, 2015
By default, now tab content will animate in from whichever direction the
ink-bar is moving.  These animations can be overridden through the
following classes:

When a tab is selected, the following classes are added in order:
1. `md-transition-rtl`: flags the animation as right-to-left
2. `ng-animate`: added at the start of all animations
3. `ng-hide-remove`
4. `ng-hide-remove-active`

When a tab is deselected, the following classes are added in order:
1. `md-transition-rtl`: flags the animation as right-to-left
2. `ng-animate`: added at the start of all animations
3. `ng-hide-add`
4. `ng-hide-add-active`

Closes #717.
Closes #811.

refactor(tabs): removes unnecessary check
@ajoslin ajoslin removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs resolution: fixed labels Jan 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants