Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

"TypeError: Cannot read property 'focus' of undefined" when using md-tabs #8111

Closed
gpiancastelli opened this issue Apr 19, 2016 · 6 comments
Closed
Assignees
Labels
has: Pull Request A PR has been created to address this issue needs: more info The issue does not contain enough information for the team to determine if it is a real bug type: bug
Milestone

Comments

@gpiancastelli
Copy link

gpiancastelli commented Apr 19, 2016

Issue #6776 has been abruptly closed (and discussion restricted) four days ago with a comment about a bug in Angular 1.5.4 due to a change which was being reverted. However, the original report used Angular 1.5.0, so it's hardly believable that the culprit could be a change that was not even made at that time.

Others in that thread reported the problem was not present in 1.5.3. But I recently had to downgrade to Angular 1.4.8 in order to have that TypeError disappear.

Specifically, it had to do with md-tabs. I was unable to had tabs shown in the most simple document while working with a bunch of combinations involving Angular 1.5.4, 1.5.5, 1.5.3, and Angular Material 1.1.0rc3. I maintain that md-tabs do not work correctly with any 1.5.x version of Angular. Also, on the Angular Material website, the Angular version used on the demos page is... guess what? 1.4.8. How convenient.

@ThomasBurleson
Copy link
Contributor

ThomasBurleson commented Apr 19, 2016

@gpiancastelli -

We will investigate this issue.

Please note that sarcasm violates our Code of Conduct "... extend courtesy and respect to everyone".

@ThomasBurleson ThomasBurleson added this to the 1.1.0 milestone Apr 19, 2016
@ThomasBurleson ThomasBurleson assigned thso and ThomasBurleson and unassigned thso Apr 19, 2016
@ThomasBurleson
Copy link
Contributor

@gpiancastelli - I am unable to reproduce any Tabs error with 1.5.5. Can you provide steps to reproduce this issue ?

@ThomasBurleson ThomasBurleson added the needs: more info The issue does not contain enough information for the team to determine if it is a real bug label Apr 19, 2016
@ThomasBurleson
Copy link
Contributor

Similar to #4388. May be fixed with #6684.

@devversion
Copy link
Member

@ThomasBurleson The PR #6684 is not updated anymore, I will resubmit a working PR if desired, just assign the issue to me if so.

@gpiancastelli
Copy link
Author

@ThomasBurleson I can confirm that Angular 1.5.5 does indeed work. Probably a browser cache issue on my part.

@ThomasBurleson
Copy link
Contributor

@gpiancastelli - Thank you for the update/reply. Closing this as a non-issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has: Pull Request A PR has been created to address this issue needs: more info The issue does not contain enough information for the team to determine if it is a real bug type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants