Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-datepicker does not focus forward to generated input element #8147

Closed
mcdwight6 opened this issue Apr 21, 2016 · 1 comment
Closed

md-datepicker does not focus forward to generated input element #8147

mcdwight6 opened this issue Apr 21, 2016 · 1 comment
Assignees
@crisbeto
Labels
has: Pull Request A PR has been created to address this issue ui: focus
Milestone
1.1.1

Comments

@mcdwight6
Copy link

When tabbing through a form with custom-defined tabindex attributes, md-datepicker does not function as expected by selecting the internally-compiled input HTML element. Instead, the tabbing sets the focus the md-datepicker element itself, not the input field and neither does it focus forward to the input. The only way to input data into the date picker input field without clicking on the field is to cycle completely through the form, after which the datepicker input field is finally selected.

I've made an example on codepen
screen shot 2016-04-20 at 6 26 13 pm
@ThomasBurleson ThomasBurleson added this to the Backlog milestone Apr 21, 2016
@mcdwight6 mcdwight6 mentioned this issue Apr 21, 2016
Closed
@mcdwight6
Copy link
Author

Seems my PR didn't pass its tests. Not sure what the errors mean though. Was trying to implement a similar solution to the one closing issue #2113. Any ideas? The errors with Travis-CI start here if it helps.

@crisbeto crisbeto assigned crisbeto and unassigned devversion Apr 21, 2016
@devversion devversion added the has: Pull Request A PR has been created to address this issue label Apr 21, 2016
@ThomasBurleson ThomasBurleson modified the milestones: Backlog, 1.1.0 Apr 21, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.1, 1.1.0 Jul 27, 2016
@crisbeto crisbeto removed the has: Pull Request A PR has been created to address this issue label Jul 28, 2016
crisbeto added a commit to crisbeto/material that referenced this issue Aug 17, 2016
@crisbeto
fix(datepicker): forward tabindex to generated input
a70d9eb 
Forwards the datepicker's tabindex to the generated input element, instead of making the wrapper element focusable.

Fixes angular#8147.
@crisbeto crisbeto added the has: Pull Request A PR has been created to address this issue label Aug 17, 2016
@crisbeto crisbeto mentioned this issue Aug 17, 2016
Merged
jelbourn pushed a commit that referenced this issue Aug 23, 2016
@crisbeto @jelbourn
fix(datepicker): forward tabindex to generated input (#9325)
6cfb542 
Forwards the datepicker's tabindex to the generated input element, instead of making the wrapper element focusable.

Fixes #8147.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
has: Pull Request A PR has been created to address this issue ui: focus
Projects
None yet
Milestone
1.1.1
Development

Successfully merging a pull request may close this issue.

feat(datepicker): support custom-defined tabindex attributes mcdwight6/material
4 participants
@ThomasBurleson @mcdwight6 @crisbeto @devversion