Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Update documentation for $mdColors #8473

Closed
sdesmond opened this issue May 16, 2016 · 1 comment
Closed

Update documentation for $mdColors #8473

sdesmond opened this issue May 16, 2016 · 1 comment
Assignees
Labels
P3: important Important issues that really should be fixed when possible.
Milestone

Comments

@sdesmond
Copy link

Looks like $mdColors.applyThemeColors now needs 3 arguments (including a scope for interpolated values). The documentation still shows only 2.

Also, the only way I can get it to work is to pass the colorExpression as a string, not as an expression. Is all this expected? If so, can you make sure to update the docs before 1.1 officially hits?

Also, was there any thought of having the scope as the last parameter and making it optional?

This does not work anymore.
$mdColors.applyThemeColors(angular.element('#idHere'), {color: 'warn'});

This seems to work now.
$mdColors.applyThemeColors(angular.element('#idHere'), $scope, "{color: 'warn'}");

@ThomasBurleson ThomasBurleson added this to the 1.1.0 milestone May 18, 2016
@ThomasBurleson ThomasBurleson added the P3: important Important issues that really should be fixed when possible. label May 18, 2016
@EladBezalel
Copy link
Member

EladBezalel commented May 31, 2016

@sdesmond new api is not having a scope anymore :)

will be updated soon !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3: important Important issues that really should be fixed when possible.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants