-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(toolbar): scroll shrink is applied to md-content within toolbar #9871
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
LGTM @ThomasBurleson. @myagoo could you try signing the CLA? Otherwise we're not allowed to merge your PR. |
|
I made those commits with my corporate email address. How can I solve this ? |
|
CLAs look good, thanks! |
|
Apparently, adding my corporate email address as a secondary email address on GitHub did the trick :D |
|
@myagoo - please squash your commits. |
|
Is this ok ? |
|
It seems like your PR still has 2 commits @myagoo, it's only supposed to have 1. You can try looking up guides on how to squash commits (like this one). |
|
I know how to squash them (i done it already), but I thought it would be good to keep separate the feature add commit from the bugfix commit. I'll squash them again under the fix flag. |
|
Nope, it should be one. You can have a list of fixes inside your commit message, e.g.: * Fixes an issue.
* Fixes some other issue. |
…in the toolbar itself
I have a
md-selectnested within mymd-toolbarwhich has scroll shrink activated.When
onChangeScrollShrinkis called,closestContentcontains themd-select'smd-content, which is later moved to the body, but it's already too late, scroll listeners have already been applied :/Duplicate of #9856
This time I cloned the repo instead of inline editing via github...