Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

@myagoo
Copy link

@myagoo myagoo commented Oct 20, 2016

I have a md-select nested within my md-toolbar which has scroll shrink activated.
When onChangeScrollShrink is called, closestContent contains the md-select's md-content, which is later moved to the body, but it's already too late, scroll listeners have already been applied :/

Duplicate of #9856
This time I cloned the repo instead of inline editing via github...

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@crisbeto
Copy link
Member

LGTM @ThomasBurleson. @myagoo could you try signing the CLA? Otherwise we're not allowed to merge your PR.

@crisbeto crisbeto added the needs: review This PR is waiting on review from the team label Oct 21, 2016
@myagoo
Copy link
Author

myagoo commented Oct 21, 2016

I made those commits with my corporate email address. How can I solve this ?

@googlebot
Copy link

CLAs look good, thanks!

@myagoo
Copy link
Author

myagoo commented Oct 21, 2016

Apparently, adding my corporate email address as a secondary email address on GitHub did the trick :D

@ThomasBurleson
Copy link
Contributor

@myagoo - please squash your commits.

@myagoo
Copy link
Author

myagoo commented Nov 8, 2016

Is this ok ?

@crisbeto
Copy link
Member

crisbeto commented Nov 8, 2016

It seems like your PR still has 2 commits @myagoo, it's only supposed to have 1. You can try looking up guides on how to squash commits (like this one).

@myagoo
Copy link
Author

myagoo commented Nov 8, 2016

I know how to squash them (i done it already), but I thought it would be good to keep separate the feature add commit from the bugfix commit. I'll squash them again under the fix flag.

@crisbeto
Copy link
Member

crisbeto commented Nov 8, 2016

Nope, it should be one. You can have a list of fixes inside your commit message, e.g.:

* Fixes an issue.
* Fixes some other issue.

@ThomasBurleson ThomasBurleson modified the milestones: 1.1.3, 1.2.0 Jan 3, 2017
@angular angular deleted a comment from googlebot Apr 22, 2020
@angular angular deleted a comment from googlebot Apr 22, 2020
@Splaktar Splaktar added pr: lgtm This PR has been approved by the reviewer and removed needs: review This PR is waiting on review from the team labels Apr 22, 2020
@Splaktar Splaktar assigned Splaktar and unassigned crisbeto and devversion Apr 22, 2020
@Splaktar Splaktar modified the milestones: Future, 1.1.23 Apr 22, 2020
@Splaktar Splaktar added needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved P2: required Issues that must be fixed. labels Apr 22, 2020
@Splaktar Splaktar added needs: demo A CodePen demo or GitHub repository is needed to demonstrate the reproduction of the issue and removed pr: lgtm This PR has been approved by the reviewer labels Jun 13, 2020
Splaktar added a commit that referenced this pull request Jun 13, 2020
- find the proper `md-content`, which should be a sibling of the toolbar
- fix scroll shrink breaking if content scrolled too quickly after page load
- improve JSDoc

Fixes #10413. Closes #9871.
Splaktar added a commit that referenced this pull request Jun 13, 2020
- find the proper `md-content`, which should be a sibling of the toolbar
- fix scroll shrink breaking if content scrolled too quickly after page load
- improve JSDoc

Fixes #10413. Closes #9871.
Splaktar added a commit that referenced this pull request Jun 13, 2020
- find the proper `md-content`, which should be a sibling of the toolbar
- fix scroll shrink breaking if content scrolled too quickly after page load
- improve JSDoc

Fixes #10413. Closes #9871.
Splaktar added a commit that referenced this pull request Jun 15, 2020
- find the proper `md-content`, which should be a sibling of the toolbar
- fix scroll shrink breaking if content scrolled too quickly after page load
- improve JSDoc

Fixes #10413. Closes #9871.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs: demo A CodePen demo or GitHub repository is needed to demonstrate the reproduction of the issue needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved P2: required Issues that must be fixed. type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants