This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(toolbar): md-scroll-shrink conflicts with md-select in toolbar #11936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
md-selectnested within amd-toolbarwhich hasmd-scroll-shrinkactivated,when
onChangeScrollShrinkis called,closestContentcontains themd-select'smd-content, which is later moved to the body, but it's already too late, scroll listeners have already been applied.md-scroll-shrinkdoes not work if content is scrolled too soon after page loadIssue Number:
Fixes #10413. Closes #9871
What is the new behavior?
md-toolbaronly looks for siblingmd-contentelements and notmd-contentelements within the toolbar itselfmd-scroll-shrinkworks even if content is scrolled soon after page loadDoes this PR introduce a breaking change?
Other information
Original PR: #9856
2nd try PR: #9871