This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
update(autoComplete): allow clear button even if directive is disabled #10603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am attempting to use md-autocomplete and 'lock' in a users selection once an autocomplete is selected. I ng-disable the directive accordingly. However, I still want the user to be able to clear the autocomplete, even if it is disabled - I simply don't want them to be able to edit the existing text. This pull request will still allow the clear button to be shown even if it is disabled. If the developer doesn't want a clear button when the control is disabled, they can simply update their boolean expression inside of the md-clear-button attribute.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
googlebot
added
the
cla: no
PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/
label
Apr 20, 2017
I signed it! |
CLAs look good, thanks! |
googlebot
added
cla: yes
PR author has signed Google's CLA: https://opensource.google.com/docs/cla/
and removed
cla: no
PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/
labels
Apr 20, 2017
ThomasBurleson
changed the title
Allow clear button even if directive is disabled
update(autoComplete): allow clear button even if directive is disabled
May 8, 2017
kara
added
pr: merge ready
This PR is ready for a caretaker to review
and removed
needs: presubmit
labels
May 9, 2017
Splaktar
added
type: enhancement
P4: minor
Minor issues. May not be fixed without community contributions.
labels
Apr 20, 2018
3 tasks
chmelevskij
pushed a commit
to chmelevskij/material
that referenced
this pull request
Jun 19, 2018
…on (angular#11248) Relates to angular#1710. Relates to angular#10603.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yes
PR author has signed Google's CLA: https://opensource.google.com/docs/cla/
P4: minor
Minor issues. May not be fixed without community contributions.
pr: merge ready
This PR is ready for a caretaker to review
type: enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am attempting to use md-autocomplete and 'lock' in a users selection once an autocomplete is selected. I ng-disable the directive accordingly. However, I still want the user to be able to clear the autocomplete, even if it is disabled - I simply don't want them to be able to edit the existing text. This pull request will still allow the clear button to be shown even if it is disabled. If the developer doesn't want a clear button when the control is disabled, they can simply update their boolean expression inside of the md-clear-button attribute.