Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

update(autoComplete): allow clear button even if directive is disabled #10603

Merged
merged 1 commit into from
May 9, 2017

Conversation

achuinard
Copy link
Contributor

I am attempting to use md-autocomplete and 'lock' in a users selection once an autocomplete is selected. I ng-disable the directive accordingly. However, I still want the user to be able to clear the autocomplete, even if it is disabled - I simply don't want them to be able to edit the existing text. This pull request will still allow the clear button to be shown even if it is disabled. If the developer doesn't want a clear button when the control is disabled, they can simply update their boolean expression inside of the md-clear-button attribute.

I am attempting to use md-autocomplete and 'lock' in a users selection once an autocomplete is selected. I ng-disable the directive accordingly. However, I still want the user to be able to clear the autocomplete, even if it is disabled - I simply don't want them to be able to edit the existing text. This pull request will still allow the clear button to be shown even if it is disabled. If the developer doesn't want a clear button when the control is disabled, they can simply update their boolean expression inside of the md-clear-button attribute.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Apr 20, 2017
@achuinard
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Apr 20, 2017
@ThomasBurleson ThomasBurleson added this to the 1.1.5 milestone May 8, 2017
@ThomasBurleson ThomasBurleson self-assigned this May 8, 2017
@ThomasBurleson ThomasBurleson changed the title Allow clear button even if directive is disabled update(autoComplete): allow clear button even if directive is disabled May 8, 2017
@kara kara added pr: merge ready This PR is ready for a caretaker to review and removed needs: presubmit labels May 9, 2017
@kara kara merged commit 2602e7b into angular:master May 9, 2017
@achuinard achuinard deleted the patch-1 branch June 24, 2017 17:22
@angular angular deleted a comment from googlebot Apr 20, 2018
@angular angular deleted a comment from googlebot Apr 20, 2018
@Splaktar Splaktar added type: enhancement P4: minor Minor issues. May not be fixed without community contributions. labels Apr 20, 2018
Splaktar added a commit that referenced this pull request Apr 20, 2018
mmalerba pushed a commit that referenced this pull request Apr 20, 2018
chmelevskij pushed a commit to chmelevskij/material that referenced this pull request Jun 19, 2018
Splaktar added a commit that referenced this pull request Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants