Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

@Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Test "should assign bindings by $onInit for ES6 classes" fails on AngularJS 1.4.
Jenkins output: https://207.254.73.19/job/angular-material1-quarterly-build-versions-testing/871/console

Issue Number:
Relates to #10977

What is the new behavior?

Tests are only run against AngularJS 1.5, 1.6, and snapshot which lines up with our current TravisCI configuration.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

"should assign bindings by $onInit for ES6 classes" fails on 1.4
add missing shebang

Relates to #10977

"should assign bindings by $onInit for ES6 classes" fails on 1.4
add missing shebang

Relates to #10977
@Splaktar Splaktar added type: chore P4: minor Minor issues. May not be fixed without community contributions. labels Jan 28, 2018
@Splaktar Splaktar added this to the 1.1.7 milestone Jan 28, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jan 28, 2018
@Splaktar Splaktar requested a review from jelbourn January 28, 2018 22:51
@mgol
Copy link
Member

mgol commented Jan 29, 2018

This looks like a breaking change so it should wait for Material 1.2.0.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar
Copy link
Contributor Author

Splaktar commented Jan 29, 2018

@mgol This just changes the test-versions.sh file which is used for testing on the above linked Jenkins. There is one test that is already failing on AngularJS 1.4 and the change for that is part of AngularJS Material 1.1.6 (needed by a Googler). This change doesn't actually change the bower-material package.json to drop support for AngularJS 1.4.

Also note that we don't test 1.4 on TravisCI anymore either (this was changed long ago).

@jelbourn jelbourn merged commit 43aa89f into master Jan 29, 2018
@Splaktar Splaktar deleted the updateTestVersions branch March 8, 2018 05:59
chmelevskij pushed a commit to chmelevskij/material that referenced this pull request Jun 19, 2018
"should assign bindings by $onInit for ES6 classes" fails on 1.4
add missing shebang

Relates to angular#10977
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. type: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants