This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(select): improve focus/blur handling on iOS #11739
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
On iOS
md-input-containers
of the selects havingclass="md-input-focused"
which should not happen.md-select
open, clicking on aninput
in amd-input-container
causes the input to get focused (floating label and ink) but then the focus gets stolen back by themd-select
'smd-input-container
. This results in a really unintuitive and janky experience.Issue Number:
Fixes #11345
What is the new behavior?
md-input-container
s can leave multipleclass="md-input-focused"
active.Does this PR introduce a breaking change?
Other information
Previously, tapping out of the
md-select
's panel would pull the focus back to themd-select
'smd-input-container
. Now, if you tap on an element outside of themd-select
's panel, themd-select
stays blurred (it gets blurred when the panel opens). If you select an option, the focus returns to themd-select
when the panel closes (both when using the mouse and keyboard).This seems like a more intuitive and correct behavior since
md-select
panels don't have backdrops, but it does change the behavior on iOS from what it was (which was pretty bad).