Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(slider): vertical slider in a scrolled container sets value to zero on all clicks #11801

Merged
Splaktar merged 8 commits into from
Jun 17, 2020
+90 −91
Merged

fix(slider): vertical slider in a scrolled container sets value to zero on all clicks #11801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d527b82
Update slider.js
Thaina Sep 26, 2019
33a7929
Update slider.spec.js
Thaina Sep 26, 2019
8706c3d
Update slider.spec.js
Thaina Sep 26, 2019
a078ac0
Update slider.spec.js
Thaina Sep 26, 2019
87db9a3
Update slider.spec.js
Thaina Sep 26, 2019
8fc9607
Update slider.spec.js
Thaina Sep 26, 2019
c43c5aa
Update slider.spec.js
Thaina Sep 26, 2019
c0b75df
Update slider.spec.js
Thaina Sep 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/slider/slider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ function SliderDirective($$rAF, $window, $mdAria, $mdUtil, $mdConstant, $mdThemi
element[0].focus();
refreshSliderDimensions();

var exactVal = percentToValue(positionToPercent(vertical ? ev.pointer.y : ev.pointer.x));
var exactVal = percentToValue(positionToPercent(vertical ? ev.srcEvent.clientY : ev.srcEvent.clientX));
var closestVal = minMaxValidator(stepValidator(exactVal));
scope.$apply(function() {
setModelValue(closestVal);
Expand All @@ -573,7 +573,7 @@ function SliderDirective($$rAF, $window, $mdAria, $mdUtil, $mdConstant, $mdThemi

element.removeClass('md-dragging');

var exactVal = percentToValue(positionToPercent(vertical ? ev.pointer.y : ev.pointer.x));
var exactVal = percentToValue(positionToPercent(vertical ? ev.srcEvent.clientY : ev.srcEvent.clientX));
var closestVal = minMaxValidator(stepValidator(exactVal));
scope.$apply(function() {
setModelValue(closestVal);
Expand Down Expand Up @@ -603,8 +603,8 @@ function SliderDirective($$rAF, $window, $mdAria, $mdUtil, $mdConstant, $mdThemi
function setSliderFromEvent(ev) {
// While panning discrete, update only the
// visual positioning but not the model value.
if (discrete) adjustThumbPosition(vertical ? ev.pointer.y : ev.pointer.x);
else doSlide(vertical ? ev.pointer.y : ev.pointer.x);
if (discrete) adjustThumbPosition(vertical ? ev.srcEvent.clientY : ev.srcEvent.clientX);
else doSlide(vertical ? ev.srcEvent.clientY : ev.srcEvent.clientX);
}

/**
Expand Down
Loading