This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(list): secondary actions give aria warning if text is in a span #11803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Splaktar
added
type: bug
a11y
Splaktar
force-pushed
the
list-ariaWarningSpan
branch
from
396c75b to
8c0256e
Compare
- an `md-list-item`'s text should be in a `<span>` or `<p>` but currently the `setupToggleAria()` function only handles `<p>` this adds support for `<span>` - add JSDoc - fix typos in comments - add docs for localizing aria labels on secondary actions Fixes #6152
Splaktar
force-pushed
the
list-ariaWarningSpan
branch
from
8c0256e to
b65e8e5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
aria-labelsare not applied to secondary actions if themd-list-itemcontains text in aspaninstead of ap.Issue Number:
Fixes #6152
What is the new behavior?
md-list-item's text should be in a<span>or<p>but currently the
setupToggleAria()function only handles<p>this adds support for
<span>Does this PR introduce a breaking change?
Other information