Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

@Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Jan 17, 2020

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Touch action styles are applied by $mdGesture.register(x, 'drag'); but they are not cleaned up on deregister if there was no touch action style previously on the element.

Before bottom sheet opened

<div class="ng-scope">

After bottom sheet opened

<div class="ng-scope" style="touch-action: pan-x;">

After bottom sheet closed

<div class="ng-scope" style="touch-action: pan-x;">

Issue Number:
Fixes #11147

What is the new behavior?

Touch action styles are applied by $mdGesture.register(x, 'drag'); and they are cleaned up on deregister, even if there was no touch action style previously on the element.

Before bottom sheet opened

<div class="ng-scope">

After bottom sheet opened

<div class="ng-scope" style="touch-action: pan-x;">

After bottom sheet closed

<div class="ng-scope" style>

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jan 17, 2020
@Splaktar Splaktar self-assigned this Jan 17, 2020
@Splaktar Splaktar added this to the 1.1.22 milestone Jan 17, 2020
@Splaktar Splaktar force-pushed the fix-bottom-sheet-style-cleanup branch from bde8fcb to fc2c95a Compare January 17, 2020 21:17
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Jan 17, 2020
@Splaktar Splaktar requested a review from mmalerba March 4, 2020 19:28
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar merged commit deb3dfc into master Mar 5, 2020
@Splaktar Splaktar deleted the fix-bottom-sheet-style-cleanup branch March 5, 2020 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review type: bug type: gestures ui: mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bottom-sheet: touch-action not reverted on cleanup

3 participants