This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(gesture): 'drag' gestures don't clean up touch action styles on parent #11845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Touch action styles are applied by
$mdGesture.register(x, 'drag');but they are not cleaned up on deregister if there was no touch action style previously on the element.Before bottom sheet opened
After bottom sheet opened
After bottom sheet closed
Issue Number:
Fixes #11147
What is the new behavior?
Touch action styles are applied by
$mdGesture.register(x, 'drag');and they are cleaned up on deregister, even if there was no touch action style previously on the element.Before bottom sheet opened
After bottom sheet opened
After bottom sheet closed
Does this PR introduce a breaking change?
Other information