fix(contact-chips): don't rely on debug info to get access to controller scope

[Splaktar]

PR Checklist

Please check that your PR fulfills the following requirements:

• The commit message follows our guidelines
• Tests for the changes have been added or this is not a bug fix / enhancement
• Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Exceptions are thrown when using Contact Chips when an app is configured for production mode ($compileProvider.debugInfoEnabled(false)). This is a regression in 1.1.11.

Issue Number:
Fixes #11699

What is the new behavior?

• fix exception when debugInfoEnabled(false) is set
• remove unused variables in tests
• remove commented out and unused code in tests

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

I didn't add a test since we don't run our tests with $compileProvider.debugInfoEnabled(false).

material/src/components/chips/js/contactChipsController.js

Line 43 in 7c913de

element.find('md-chips').scope().$watchCollection('$mdChipsCtrl.items', function() {

is depending upon debug info being enabled. More details in the AngularJS Production Guide.

[mmalerba]

LGTM