This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
docs: fix hljs examples breaking #11881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Splaktar
added
P1: urgent
- pin `dgeni-packages` to `0.27.5` as `0.28.0` includes a breaking change - https://github.com/angular/dgeni-packages/blob/master/CHANGELOG.md#0280-12-july-2019 - pin `mkdirp` to `0.5.1` to be compatible with `dgeni-packages@0.27.x` - angular/dgeni-packages#287
Splaktar
force-pushed
the
fix-hljs-examples
branch
from
1ce4322 to
10669da
Compare
This was referenced Jun 5, 2021
Splaktar
added a commit
to DevIntent/material
that referenced
this pull request
Nov 18, 2021
- Use a resolution override for `marked` to be compatible with latest dgeni-packages - before: found 64 vulnerabilities (1 low, 43 moderate, 17 high, 3 critical) - after: found 51 vulnerabilities (1 low, 30 moderate, 17 high, 3 critical) - fix some npm audit issues Relates to angular/angular.js#17163. Relates to angular#11881. Relates to angular#12111.
4 tasks
Splaktar
added a commit
that referenced
this pull request
Nov 19, 2021
- Use a resolution override for `marked` to be compatible with latest dgeni-packages - before: found 64 vulnerabilities (1 low, 43 moderate, 17 high, 3 critical) - after: found 51 vulnerabilities (1 low, 30 moderate, 17 high, 3 critical) - fix some npm audit issues Relates to angular/angular.js#17163. Relates to #11881. Relates to #12111.
Splaktar
added a commit
that referenced
this pull request
Nov 22, 2021
- Use a resolution override for `marked` to be compatible with latest dgeni-packages - before: found 64 vulnerabilities (1 low, 43 moderate, 17 high, 3 critical) - after: found 51 vulnerabilities (1 low, 30 moderate, 17 high, 3 critical) - fix some npm audit issues Relates to angular/angular.js#17163. Relates to #11881. Relates to #12111.
superheri
pushed a commit
to superheri/material
that referenced
this pull request
Nov 30, 2021
- Use a resolution override for `marked` to be compatible with latest dgeni-packages - before: found 64 vulnerabilities (1 low, 43 moderate, 17 high, 3 critical) - after: found 51 vulnerabilities (1 low, 30 moderate, 17 high, 3 critical) - fix some npm audit issues Relates to angular/angular.js#17163. Relates to angular#11881. Relates to angular#12111.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number:
N/A
What is the new behavior?
dgeni-packagesto0.27.5as0.28.0includes a breaking changemkdirpto0.5.1to be compatible withdgeni-packages@0.27.xDoes this PR introduce a breaking change?
Other information
@petebacondarwin I'm not sure if this is a bug in
dgeni-packagesor just a breaking change. If it's a breaking change, it's not clear to me how to fix it based on thedgeni-packagesandmarkedchangelogs.