This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(select): height changes when disabled #11886
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
md-select's height changes when disabledIssue Number:
Fixes #11812
What is the new behavior?
md-select's height no longer changes when disabledmd-select's disabled border background-position asmd-inputmd-selectinside of anmd-input-containeruses moremd-inputSCSS variablesmd-input-containerelements$select-border-width-defaultSCSS variableDoes this PR introduce a breaking change?
Other information
This change should not break any apps, but it may allow them to remove some CSS hacks to fix the previous issue with the selects loosing
1pxof height when disabled. If there are screenshot tests involved, they may fail for disabled inputs due to the1pxchange in position, but this new position should be the correct position and matches the non-disabled position.We'll try this out in an RC and determine if this will be problematic for production apps or not. If it turns out to be, we'll revert this and push it to
1.2.0.