Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

@Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Apr 15, 2020

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[x] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • We display a Bower icon on the landing page along with an "Install with Bower" tooltip, but Bower has been deprecated for years.
  • We use an old, out of date icon for GitHub and NPM on our landing page.
  • The 'View Demo' button appears for the md-autofocus directive which doesn't have a demo.

Issue Number:
N/A

What is the new behavior?

  • remove Bower references
  • update GitHub and NPM icons
  • update README.md
    • fix typos
    • update example versions
    • remove references to Bower
  • fix 'View Demo' button appearing for directives w/o demos

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Before

Screen Shot 2020-04-15 at 16 24 52

After

Screen Shot 2020-04-15 at 16 24 34

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Apr 15, 2020
@Splaktar Splaktar self-assigned this Apr 15, 2020
@Splaktar Splaktar added this to the 1.1.22 milestone Apr 15, 2020
@Splaktar Splaktar added type: docs P2: required Issues that must be fixed. labels Apr 15, 2020
@Splaktar Splaktar requested a review from andrewseguin April 15, 2020 20:23
@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review pr: merge safe labels Apr 15, 2020
- update README.md
  - fix typos
  - update example versions
  - remove references to Bower
- fix 'View Demo' button appearing for directives w/o demos
@Splaktar Splaktar force-pushed the update-npm-github-icons branch from c20590d to 2ade3e6 Compare April 15, 2020 20:34
@Splaktar Splaktar changed the title docs: remove Bower references, update GitHub and NPM icons docs: fix View Demo button for directives w/o a demo. update icons, Bower references Apr 15, 2020
@andrewseguin andrewseguin added the pr: lgtm This PR has been approved by the reviewer label Apr 21, 2020
@Splaktar Splaktar merged commit 5c75b12 into master Apr 21, 2020
@Splaktar Splaktar deleted the update-npm-github-icons branch April 21, 2020 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants