Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(select): perform correct position calculation in rtl for long labels #11894

Merged
Splaktar merged 1 commit into from
Apr 30, 2020
Merged

fix(select): perform correct position calculation in rtl for long labels #11894

Splaktar merged 1 commit into from
Apr 30, 2020

Conversation

@marosoft
Copy link
Contributor

@marosoft marosoft commented Apr 26, 2020

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Position of the select is not calculated properly when rtl is on.

Issue Number:
#10395

What is the new behavior?

Position of the select is calculated properly when rtl is on as well.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Apr 26, 2020
@marosoft
Copy link
Contributor Author

marosoft commented Apr 26, 2020

CodePen with the fix in place

Splaktar
Splaktar approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for posting the CodePen w/ the fix!

@Splaktar Splaktar added this to the 1.1.23 milestone Apr 27, 2020
@Splaktar Splaktar self-assigned this Apr 27, 2020
@Splaktar Splaktar requested a review from jelbourn April 27, 2020 18:01
@Splaktar Splaktar added i18n: bi-directional This issue is related to internationalization and right to left languages P3: important Important issues that really should be fixed when possible. pr: merge ready This PR is ready for a caretaker to review type: bug labels Apr 27, 2020
jelbourn
jelbourn approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar merged commit 9f49e10 into angular:master Apr 30, 2020
@Splaktar Splaktar mentioned this pull request Apr 30, 2020
Closed
@Splaktar Splaktar linked an issue Apr 30, 2020 that may be closed by this pull request
select: position is calculated incorrectly in rtl when long label is used #10395
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@jelbourn jelbourn jelbourn approved these changes

@Splaktar Splaktar Splaktar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Splaktar Splaktar

Labels

cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ i18n: bi-directional This issue is related to internationalization and right to left languages P3: important Important issues that really should be fixed when possible. pr: merge ready This PR is ready for a caretaker to review type: bug

Projects

None yet

Milestone

1.1.23

Development

Successfully merging this pull request may close these issues.

select: position is calculated incorrectly in rtl when long label is used

4 participants

@marosoft @jelbourn @Splaktar @googlebot