-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(navBar): update inkbar on screen resize #11912
Conversation
- changed how inkbar is moved - use transform to scale and translate the inkbar - also add debounced update to window resize Closes #10121
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@chmelevskij can you please consent to your changes being used here (I just fixed issues from the rebase)? Please add a comment with |
|
@googlebot I consent |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
mmalerba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@landgenoot can you please open a new issue with a CodePen/StackBlitz reproduction? It sounds similar to #11036, but affects |
|
The event subscription is not for onResize, but for the debounced onResize (which is a different function than onResize). Hence the unsubscription does nothing, leaking a resize event handler whenever md-nav-bar is shown on a page. |

PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The ink bar below the tab buttons does not update it's position if an item with
flexexists besidesmd-nav-items.Issue Number:
Fixes #10121
Closes #11042
What is the new behavior?
Does this PR introduce a breaking change?
Other information
This PR takes over PR #11042 to resolve issues introduced via rebase.
Caretaker note
The CLA was signed in the previous PR.