Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

@Splaktar
Copy link
Contributor

@Splaktar Splaktar commented May 15, 2020

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The ink bar below the tab buttons does not update it's position if an item with flex exists besides md-nav-items.

Issue Number:
Fixes #10121
Closes #11042

What is the new behavior?

  • update inkbar on screen resize
  • changed how inkbar is moved
  • use transform to scale and translate the inkbar
  • also add debounced update to window resize

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This PR takes over PR #11042 to resolve issues introduced via rebase.

Caretaker note

The CLA was signed in the previous PR.

chmelevskij and others added 2 commits May 14, 2020 22:45
- changed how inkbar is moved
- use transform to scale and translate the inkbar
- also add debounced update to window resize

Closes #10121
@Splaktar Splaktar added type: bug ui: responsive ui: CSS g3: reported The issue was reported by an internal or external product team. P2: required Issues that must be fixed. g3: sync labels May 15, 2020
@Splaktar Splaktar added this to the 1.1.23 milestone May 15, 2020
@Splaktar Splaktar self-assigned this May 15, 2020
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label May 15, 2020
@Splaktar
Copy link
Contributor Author

@chmelevskij can you please consent to your changes being used here (I just fixed issues from the rebase)? Please add a comment with @googlebot I consent.

@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label May 15, 2020
@Splaktar Splaktar requested a review from mmalerba May 15, 2020 02:53
@chmelevskij
Copy link
Contributor

@googlebot I consent

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels May 15, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label May 15, 2020
@Splaktar Splaktar merged commit a3a977a into master May 15, 2020
@Splaktar Splaktar deleted the fix-nav-bar-ink branch May 15, 2020 18:14
@landgenoot
Copy link

This PR breaks the position of the inkbar if there is a margin set on the md-nav-bar

image
Example with margin-left: 60px on .md-nav-bar

@Splaktar
Copy link
Contributor Author

Splaktar commented Jul 29, 2020

@landgenoot can you please open a new issue with a CodePen/StackBlitz reproduction?

It sounds similar to #11036, but affects md-nav-bar instead.

@vbraun
Copy link

vbraun commented Oct 11, 2021

The event subscription

angular.element($window).on('resize', $mdUtil.debounce(onResize, 300));

is not for onResize, but for the debounced onResize (which is a different function than onResize). Hence the unsubscription

angular.element($window).off('resize', onResize);

does nothing, leaking a resize event handler whenever md-nav-bar is shown on a page.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ g3: reported The issue was reported by an internal or external product team. P2: required Issues that must be fixed. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug ui: CSS ui: responsive

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mdNavbar > mdNavInkBar: does not update position on screen resize

6 participants