Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(select): revert removal of support for ng-selected on md-options #11916

Merged
Splaktar merged 1 commit into from
May 21, 2020
Merged

fix(select): revert removal of support for ng-selected on md-options #11916

Splaktar merged 1 commit into from
May 21, 2020

Conversation

@Splaktar
Copy link
Contributor

@Splaktar Splaktar commented May 20, 2020

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

In 1.1.22, we accidentally removed support for the undocumented ng-selected API on md-option.

Issue Number:
Fixes #11914

What is the new behavior?

  • revert removal of support for ng-selected on md-options
  • add unit test to ensure ng-selected support continues to work
  • add docs for ng-selected on md-option

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Splaktar
fix(select): revert removal of support for ng-selected on md-options
5a33ce3 
- add unit test to ensure `ng-selected` support continues to work
- add docs for `ng-selected` on `md-option`

Fixes #11914
@Splaktar Splaktar self-assigned this May 20, 2020
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label May 20, 2020
@Splaktar Splaktar added this to the 1.1.23 milestone May 20, 2020
@Splaktar Splaktar added P2: required Issues that must be fixed. severity: regression This issue is related to a regression pr: merge ready This PR is ready for a caretaker to review type: bug labels May 20, 2020
@Splaktar Splaktar requested a review from jelbourn May 20, 2020 23:29
jelbourn
jelbourn approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar merged commit 546bd84 into master May 21, 2020
@Splaktar Splaktar deleted the select-ng-selected-init branch May 21, 2020 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jelbourn jelbourn jelbourn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Splaktar Splaktar

Labels

cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug

Projects

None yet

Milestone

1.1.23

Development

Successfully merging this pull request may close these issues.

select: ng-selected on a md-option is not working on page load

3 participants

@Splaktar @jelbourn @googlebot