Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

@Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • tabs API docs and types have issues
  • md-no-disconnect API docs
  • missing parameters
  • invalid parameters

Issue Number:
Fixes #10407

What is the new behavior?

  • improve correctness of API docs and types
  • re-add missing md-no-disconnect API docs, but mark the API deprecated
  • improve JSDoc
  • add missing parameters
  • remove invalid parameters

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

- re-add missing `md-no-disconnect` API docs, but mark the API deprecated
- improve JSDoc
- add missing parameters
- remove invalid parameters

Fixes #10407
@Splaktar Splaktar self-assigned this May 31, 2020
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label May 31, 2020
@Splaktar Splaktar added this to the 1.1.23 milestone May 31, 2020
@Splaktar Splaktar added P3: important Important issues that really should be fixed when possible. type: docs labels May 31, 2020
@Splaktar Splaktar requested a review from jelbourn May 31, 2020 04:13
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label May 31, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar merged commit a17ef4f into master Jun 5, 2020
@Splaktar Splaktar deleted the tabs-docs-cleanup branch June 5, 2020 07:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P3: important Important issues that really should be fixed when possible. pr: merge ready This PR is ready for a caretaker to review type: docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Boolean attrs that should contain interpolation

3 participants