Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

@Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Jun 6, 2020

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • we allow overriding list-item padding for non-clickable items only

Issue Number:
Fixes #10384

What is the new behavior?

  • we allow overriding list-item padding for clickable and non-clickable items

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jun 6, 2020
@Splaktar Splaktar self-assigned this Jun 6, 2020
@Splaktar Splaktar added the P3: important Important issues that really should be fixed when possible. label Jun 6, 2020
@Splaktar Splaktar added this to the 1.1.23 milestone Jun 6, 2020
@Splaktar Splaktar requested a review from jelbourn June 6, 2020 01:22
@Splaktar Splaktar added ui: CSS type: bug pr: merge ready This PR is ready for a caretaker to review labels Jun 6, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar merged commit f7d9027 into master Jun 8, 2020
@Splaktar Splaktar deleted the list-scss-consistency branch June 8, 2020 07:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P3: important Important issues that really should be fixed when possible. pr: merge ready This PR is ready for a caretaker to review type: bug ui: CSS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

list-item: SCSS padding inconsistent between clickable / non-clickable items

3 participants