Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

@Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • The focused option's md-focused class is not removed when the menu is closed. When the menu is opened again, another option may be auto focused resulting in two options being decorated with md-focused. Repeating this can lead to many options with md-focused.
  • There are no tests for select menu options' focus decoration.

Issue Number:
Fixes #11927

What is the new behavior?

  • remove the focused option's md-focused class when the menu is closed
  • add tests for select menu options' focus decoration
  • improve some JSDoc for interimElement

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

- add tests for select menu options' focus decoration
- improve some JSDoc for interimElement

Fixes #11927
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jun 14, 2020
@Splaktar Splaktar self-assigned this Jun 14, 2020
@Splaktar Splaktar added this to the 1.1.23 milestone Jun 14, 2020
@Splaktar Splaktar added a11y This issue is related to accessibility P2: required Issues that must be fixed. type: bug labels Jun 14, 2020
@Splaktar Splaktar requested a review from andrewseguin June 14, 2020 07:37
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Jun 14, 2020
@andrewseguin andrewseguin added the pr: lgtm This PR has been approved by the reviewer label Jun 15, 2020
@Splaktar Splaktar merged commit 5a7e967 into master Jun 15, 2020
@Splaktar Splaktar deleted the select-focus-class-not-removed branch June 15, 2020 15:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

select: md-focused not removed from options on panel close

3 participants