Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(layout): Syntax Error: Token '&&' not a primary expression #11940

Merged
Splaktar merged 1 commit into from
Jun 17, 2020
Merged

fix(layout): Syntax Error: Token '&&' not a primary expression #11940

Splaktar merged 1 commit into from
Jun 17, 2020

Conversation

@Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Jun 17, 2020 •
edited
Loading

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • origValue is not defined, thus it always checks the value against undefined

Issue Number:
Fixes #10935

What is the new behavior?

  • revert change to not set origValue so that value is actually checked against the original value

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This issue was caused by PR #10462 which was trying to deal with this change to AngularJS 1.6.0.

Workaround and more details on why the parsing fails here.

@Splaktar
fix(layout): Syntax Error: Token '&&' not a primary expression
0378ba8 
- revert change to not set `origValue`
- this was always checking against `undefined`

Fixes #10935
@Splaktar Splaktar added this to the 1.1.23 milestone Jun 17, 2020
@Splaktar Splaktar self-assigned this Jun 17, 2020
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jun 17, 2020
@Splaktar Splaktar added hotlist: Angular 1.6 support P3: important Important issues that really should be fixed when possible. severity: regression This issue is related to a regression type: bug pr: merge ready This PR is ready for a caretaker to review labels Jun 17, 2020
@Splaktar Splaktar requested a review from mmalerba June 17, 2020 07:11
mmalerba
mmalerba approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar merged commit 1bd1a97 into master Jun 17, 2020
@Splaktar Splaktar deleted the layout-fix-parsing-exception branch June 17, 2020 23:44
@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Jun 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mmalerba mmalerba mmalerba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Splaktar Splaktar

Labels

cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P3: important Important issues that really should be fixed when possible. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug

Projects

None yet

Milestone

1.1.23

Development

Successfully merging this pull request may close these issues.

Can't use either *show* or *hide* words as bindings

3 participants

@Splaktar @mmalerba @googlebot