Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(datepicker): support ng-model-options timezone w/ Moment #11951

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number:
Fixes #11945. Fixes #10598.

What is the new behavior?

  • support ng-model-options timezone w/ Moment
  • add demo for ng-model-options timezone support
  • pass datepicker's ng-model-options on to its calendar
  • fix case where datepicker's model is initially out of sync with the input value

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This just merges the change in the 1.1.x branch to master.

- fix case where datepicker's model is initially out of sync
  with the input value
- add demo for `ng-model-options` timezone support
- pass datepicker's `ng-model-options` on to its calendar

Fixes #11945. Fixes #10598.
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jun 29, 2020
@Splaktar Splaktar added P1: urgent Urgent issues that should be addressed in the next minor or patch release. type: bug i18n: localization This issue is related to internationalization pr: merge ready This PR is ready for a caretaker to review labels Jun 29, 2020
@Splaktar Splaktar self-assigned this Jun 29, 2020
@Splaktar Splaktar merged commit e24d09c into master Jun 29, 2020
@Splaktar Splaktar deleted the datepicker-merge-to-master branch June 29, 2020 17:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ i18n: localization This issue is related to internationalization P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
2 participants