This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
feat(icon): svg icons with styles and simple img elements #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use XMLHttpRequest to load SVG as XML and inject into directive. Note this will not support executing attached SVG scripts. - Use <img> element to load as static (not CSS style capable) SVG images. This may be desirable in situations dealing with many copies of complex SVG icons, to avoid exploding the element count in the DOM.
- to allow loading resources for component directives that require them. - proxy config/fixtures path to /fixtures/ in tests.
- load an svg icon from the fixtures path and verify it is properly embedded in icon container.
- enable jsdocs blocks to show page in docs site. - reformat directive definition to model after button. - update styles to apply to img and svg elements. -
- dry up tests with a setup fixture to make implementing more of them simple.
- embed icon as svg or img. - embed icon as svg and manipulate with CSS filters. - embed icon as svg and manipulate particular svg elements with CSS. - add border color media icon to demonstrate styling svg child elements.
- fixes issue where svg icon ends up being the viewport height on firefox.
|
@ThomasBurleson can you provide some input? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the md-icon directive to support CSS styling and loading of .svg file icons directly. Add documentation, tests, and examples.
Questions:
svgso that styling may be applied to svg elements. is it better to default to theimgrendering, which would pollute the dom less but not svg element styling?