Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Update toast.scss #1386

Closed
wants to merge 1 commit into from
Closed

Update toast.scss #1386

wants to merge 1 commit into from

Conversation

ChristopheBoucaut
Copy link

I propose replace absolute with fixed, because the toast doesn't move when user scroll the page and it finds himself in the middle of the page (it's ugly).

Currently =>
Start: http://img4.hostingpics.net/pics/767337good.png
Scroll: http://img4.hostingpics.net/pics/503064bad.png

With fixed =>
Scroll : http://img4.hostingpics.net/pics/992306withfixed.png

Review on Reviewable

I propose replace absolute with fixed, because the toast doesn't move when user scroll the page and it finds himself in the middle of the page (it's ugly).

Currently => 
Start: http://img4.hostingpics.net/pics/767337good.png
Scroll: http://img4.hostingpics.net/pics/503064bad.png

With fixed =>
Scroll : http://img4.hostingpics.net/pics/992306withfixed.png
@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@ChristopheBoucaut
Copy link
Author

i signed

@googlebot
Copy link

CLAs look good, thanks!

@ilanbiala
Copy link
Contributor

Has to do with #1106.

@ChristopheBoucaut
Copy link
Author

Okey :) thanks.

@ilanbiala
Copy link
Contributor

It doesn't need to be closed, I'm just referencing the issue that it would fix.

@ThomasBurleson ThomasBurleson modified the milestone: 0.9.0 Mar 31, 2015
@ThomasBurleson
Copy link
Contributor

@rschmukler - I think this change must be rejected; as we do not want position:fixed. Do you agree ?

@birdcw
Copy link

birdcw commented Apr 20, 2015

If not fixed, could you just set the toast to close on a swipe/scroll event? To me, it seems like a reasonable assumption that the user is dismissing the toast when they scroll

@ThomasBurleson ThomasBurleson modified the milestones: 0.11.0, 0.9.0, Backlog Jul 1, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 0.11.0, Backlog Jul 3, 2015
@rschmukler
Copy link
Contributor

Closing this issue - position fixed would violate the spec on blocking FABs. Ultimately we need a better solution that resolves both. @birdcw please open a new issue if you still think we should have the close on scroll

@rschmukler rschmukler closed this Jul 7, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants