-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Conversation
I propose replace absolute with fixed, because the toast doesn't move when user scroll the page and it finds himself in the middle of the page (it's ugly). Currently => Start: http://img4.hostingpics.net/pics/767337good.png Scroll: http://img4.hostingpics.net/pics/503064bad.png With fixed => Scroll : http://img4.hostingpics.net/pics/992306withfixed.png
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
i signed |
CLAs look good, thanks! |
Has to do with #1106. |
Okey :) thanks. |
It doesn't need to be closed, I'm just referencing the issue that it would fix. |
@rschmukler - I think this change must be rejected; as we do not want |
If not fixed, could you just set the toast to close on a swipe/scroll event? To me, it seems like a reasonable assumption that the user is dismissing the toast when they scroll |
I propose replace
absolute
withfixed
, because the toast doesn't move when user scroll the page and it finds himself in the middle of the page (it's ugly).Currently =>
Start: http://img4.hostingpics.net/pics/767337good.png
Scroll: http://img4.hostingpics.net/pics/503064bad.png
With fixed =>
Scroll : http://img4.hostingpics.net/pics/992306withfixed.png