Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Fixes for safari #2066

Closed
wants to merge 1 commit into from
Closed

Conversation

JulianWielga
Copy link
Contributor

safari has problem with big body of <style> tag created by js

@JulianWielga JulianWielga mentioned this pull request Mar 29, 2015
@ThomasBurleson ThomasBurleson modified the milestone: 0.9.0 Mar 31, 2015
@ThomasBurleson
Copy link
Contributor

@JulianWielga

  • Please squash your commits
  • Please rebase from current master and test
  • Please provide a CodePen or Plunkr that demonstrates this issue and PR fixes.

@ThomasBurleson ThomasBurleson added needs: demo A CodePen demo or GitHub repository is needed to demonstrate the reproduction of the issue needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved labels Apr 1, 2015
styleString was too big for safari to parse when appending with
innerHTML

grid list in safari, fixed typo

breaks grid list in safari

another, better fix for safari

safari has problem with too long <style> body

fixed broken styles order

style
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@ilanbiala
Copy link
Contributor

@JulianWielga why was this PR closed?

@JulianWielga JulianWielga reopened this Apr 1, 2015
@googlebot
Copy link

CLAs look good, thanks!

@JulianWielga
Copy link
Contributor Author

@ilanbiala not noticed, probably by mistake

@JulianWielga
Copy link
Contributor Author

@ThomasBurleson

@ThomasBurleson ThomasBurleson self-assigned this Apr 2, 2015
@ThomasBurleson
Copy link
Contributor

@JulianWielga - fast response 👍 Thx

@ecunal
Copy link

ecunal commented Apr 3, 2015

Any updates on this matter?

@JulianWielga I got your changes and built angular-material.js and css locally, however our page with a md-grid-list is still broken as before in Safari. I also tried to get the angular-material.js library you built and used in the codepen demos, but still no luck. Are there any other changes that I must apply?

@ThomasBurleson ThomasBurleson removed the needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved label Apr 3, 2015
rschmukler pushed a commit that referenced this pull request Apr 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: demo A CodePen demo or GitHub repository is needed to demonstrate the reproduction of the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants