Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(gestures): fixes issue with non-clickable links #2248

Closed

Conversation

kennethcachia
Copy link
Contributor

@ajoslin @ThomasBurleson

This is a possible fix for #1792.
Broken demo in #1792: http://codepen.io/ThomasBurleson/pen/MYRvwy?editors=100
Fixed demo in #1792: http://codepen.io/kennethcachia/pen/azgwWg

Current status
Demo: http://codepen.io/kennethcachia/pen/PwrjGp?editors=100

// callback is executed
$('#id').on('click', function() { .. });

// callback is executed
$('#id').on('$md.pressdown', function() { .. }); 

// callback is executed
document.querySelector('#id').on('click', function() { .. }); 

// callback is not executed
document.querySelector('#id').on('$md.pressdown', function() { .. });

It's not a complete fix but might be enough for this and similar issues in 0.9.0. Makes sense?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ajoslin ajoslin added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Apr 10, 2015
@ThomasBurleson ThomasBurleson self-assigned this Apr 10, 2015
@ThomasBurleson ThomasBurleson added this to the 0.9.0 milestone Apr 10, 2015
@ajoslin ajoslin removed the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Apr 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants