This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(specs): failing specs now exit with non zero #2535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Running karma on ci was not exiting with non zero code, giving the impression the specs passed.
ThomasBurleson
added a commit
that referenced
this pull request
May 11, 2015
Running karma on ci was not exiting with non zero code, giving the impression the specs passed Closes #2535.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running karma on ci was not exiting with non zero code, giving the impression the specs passed.
Here is an example of a failing PR without this logic:
https://travis-ci.org/angular/material/builds/59751055
Here is an example using code from this PR:
https://travis-ci.org/matthewrfindley/material/builds/59786743
With this pull request, I am making an assumption that
gulp karmashould run all three versions of the specs (unminified, minified and minified with jQuery). Given this was the existing behavior, all specs will run in each context and report with a non zero exit code when they are all done.