This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(slider): increment the value properly when step is a decimal number #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajoslin
added
the
in progress
| return Math.round(value / step) * step; | ||
| var formattedValue = (Math.round(value / step) * step); | ||
| // Format to 3 digits after the decimal point - fixes #2015. | ||
| return parseFloat(formattedValue.toFixed(3)); |
There was a problem hiding this comment.
You should use return Math.round(formattedValue * 1000) / 1000. It's faster.
JSperf: http://jsperf.com/math-round-vs-tofixed2/5
|
Thanks @Kiougar! Pushed an update. |
|
It's not clear to me that this resolves the issue. Previously |
|
Hey @mprentic-harris! |
ThomasBurleson
removed
the
in progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2015