This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(select): expose and preserve aria-label #2672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajoslin
added
the
in progress
marcysutton
force-pushed
the
wip-select-arialabel
branch
from
a7ca359
to
23ef8ff
Compare
marcysutton
added
resolution: fixed
and removed
in progress
|
@marcysutton - love your PRs with unit tests added. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select previously used
aria-labelledbypointing to<md-select-label>, which worked fine until a value was selected, wiping out the accessible name for the select. To inform screen reader users what a particular select is for, the contents fromplaceholder=""or<md-select-label>are copied to anaria-labelattribute on<md-select>instead. A warning is logged to the console if neither value is present.Closes #1893