This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(gesture): fix conflicts with Ionic #2761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajoslin
added
the
in progress
| */ | ||
| document.addEventListener('click', function clickHijacker(ev) { | ||
| var isKeyClick = ev.clientX === 0 && ev.clientY === 0; | ||
| if (!isKeyClick && !ev.$material) { | ||
| if (!isKeyClick && !ev.$material && !ev.isIonicTap) { |
There was a problem hiding this comment.
Is there a way to make this less specific to Ionic, so we don't have it so closely coupled with Angular Material internals?
There was a problem hiding this comment.
Unfortunately I don't know how yet. I agree though, this is not ideal but we can push this and improve it if we find a better alternative.
There was a problem hiding this comment.
@marcysutton - great question.
Kenneth and I considered ideas such using GestureProvider to register 'shouldIgnore` callbacks. But for this 1 special case, it seemed more trouble with little ROI.
ThomasBurleson
added
resolution: fixed
and removed
in progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1528
This is an auto-fix for Ionic conflicts. Alternatively, you can currently fix Ionic conflicts via:
$mdGestureProvider.skipClickHijack();