This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
feat(linear-progress): Add linear progress indicator #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| bar1.css('width', clamp(value).toString() + '%'); | ||
| }); | ||
|
|
||
| $timeout(function(){container.addClass('ready');}); |
There was a problem hiding this comment.
Should we use an $$rAF here?
$$rAF( function(){
var container = element.find('.container');
container.addClass('ready');
});
| @@ -66,6 +66,12 @@ | |||
| user-select: $val; | |||
| } | |||
|
|
|||
| @mixin animation($animation) { | |||
There was a problem hiding this comment.
If you rebase against master, we have an animation mixin already.
|
Note added about ARIA on the progress element itself. If it is showing progress of a specific region of the page, we may want to add code that establishes a relationship between the progress indicator and the other region: "If the More about the |
This linear progress directive displays a simple, animated loading bar. There are four display modes: determinate, indeterminate, buffer and query. Closes #187
Closed
EisenbergEffect
force-pushed
the
wip-linear-progress
branch
from
9ce7516
to
8b5213a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This linear progress directive displays a simple, animated loading bar. There are four display modes: determinate, indeterminate, buffer and query.
Closes #187