This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(linear_progress): Add aria, tests and better animations #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| container = angular.element(element[0].querySelector('.container')); | ||
| compile: function compile(tElement, tAttrs, transclude) { | ||
| tElement.attr('aria-valuemin', 0); | ||
| tElement.attr('aria-valuemax', 100); |
There was a problem hiding this comment.
Will there ever be an arbitrary maximum value? I wonder if we need to accommodate aria-valuetext for that. https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-valuetext_attribute
EisenbergEffect
force-pushed
the
fixup-linear-progress-2
branch
from
3eae774
to
8ff447c
Compare
ThomasBurleson
force-pushed
the
master
branch
from
56e270a
to
fd7697d
Compare
This set of changes adds expected progress-bar aria attributes. It also adds a small unit test suite. Finally, the animations have been converted to transforms in order to engage hardware acceleration, particularly on mobile devices. Fixes #297
EisenbergEffect
force-pushed
the
fixup-linear-progress-2
branch
from
74ec064
to
8597604
Compare
|
Merged via 3b38627. Good stuff Rob. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes adds expected progress-bar aria attributes. It also
adds a small unit test suite. Finally, the animations have been
converted to transforms in order to engage hardware acceleration,
particularly on mobile devices.
Fixes #297