Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(mdTooltip): fix regression that broke tooltips on Firefox #3467

Closed
wants to merge 1 commit into from

Conversation

Splaktar
Copy link
Member

Remove check for pointer-events not equal to none to resolve non-visible tooltips on Firefox.
Add Chrome & Firefox as default test runners in karma task to avoid regressions like this in the future.

Closes #3047, #3250 and #3430

Review on Reviewable

@Splaktar
Copy link
Member Author

I would be happy to hear if this code may have existed for a reason. If so, we'll want to add a test for whatever that reason is.

We probably don't want to be missing regressions like this on releases since they would be easily caught by the automated tests had they been run for Firefox instead of just PhantomJS. It only adds 3s to the task and there is a karma-fast task for faster development runs.

Removed Chrome as a default since it fails to execute on Travis. It's possible to add Chrome when not in Travis and remove it when in Travis if that is desirable.

@Splaktar Splaktar force-pushed the wip/firefox-tooltip-fix branch from f51f2c8 to c20b583 Compare June 26, 2015 03:44
@Splaktar
Copy link
Member Author

This attempts to improve on the proposed PR #3447

Remove check for pointer-events not equal to none to resolve non-visible tooltips on Firefox.
Add Chrome & Firefox as default test runners in karma task to avoid regressions like this in the future.

Closes #3047, #3250 and #3430
@Splaktar Splaktar force-pushed the wip/firefox-tooltip-fix branch from c20b583 to c5dbcbd Compare July 1, 2015 04:17
@Splaktar Splaktar closed this in 6fc9212 Jul 1, 2015
Splaktar added a commit that referenced this pull request Jul 4, 2015
Remove check for pointer-events not equal to none to resolve non-visible tooltips on Firefox.
Add Chrome & Firefox as default test runners in karma task to avoid regressions like this in the future.
Improve and automate use of ngAnimateMock

Fixes #3047. Fixes #3250.  Fixes #3430. Closes #3467.
@Splaktar Splaktar deleted the wip/firefox-tooltip-fix branch August 21, 2015 14:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mdTooltip is broken in Firefox when checking 'pointer-events' to not be 'none'
1 participant