Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(fabSpeedDial): fix many visual issues #3468

Closed
wants to merge 1 commit into from

Conversation

topherfangio
Copy link
Contributor

  • maintain state when focusing/bluring/tabbing through actions

    speed dial would previously show a very short and erroneous animation
    when tabbing, or rapidly blurring/focusing, through child items

  • add demo showing tooltip usage

  • fix $digest in-progress error when opening a dialog

    cebor reported a $digest in progress bug when trying to open a dialog
    from within the speed dial; haven't figured out how to create a test
    that demonstrates it, but I added a demo which shows failure

  • animations fail on Safari

    update webkitTransform styles and set height to initial instead of 100%

closes #3213, closes #3338, closes #3277, closes #3236, closes #3375

Review on Reviewable


angular.module('fabSpeedDialModalDemo', ['ngMaterial'])
.controller('AppCtrl', function($scope, $mdDialog) {
$scope.demo = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to use controllerAs syntax.

@gkalpak
Copy link
Member

gkalpak commented Jun 26, 2015

It would be better to avoid $timeout, as it will cause an extra digest (if one is already running).

You might be able to avoid $timeout by using scope.$evalAsync().

@topherfangio topherfangio force-pushed the wip/speed_dial_tooltips branch from 9335f61 to d09952f Compare June 28, 2015 06:12
@topherfangio
Copy link
Contributor Author

@gkalpak Done and done :-)

Please let me know if you see anything else that needs changing!

$scope.demo = {
topDirections: ['left', 'up'],
bottomDirections: ['down', 'right'],
.controller('DemoCtrl', function($scope) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to inject $scope any more.

@gkalpak
Copy link
Member

gkalpak commented Jun 28, 2015

@topherfangio, careful what you ask for :)

 * maintain state when focusing/bluring/tabbing through actions

   speed dial would previously show a very short and erroneous animation
   when tabbing, or rapidly blurring/focusing, through child items

 * add demo showing tooltip usage

 * fix $digest in-progress error when opening a dialog

   cebor reported a $digest in progress bug when trying to open a dialog
   from within the speed dial; haven't figured out how to create a test
   that demonstrates it, but I added a demo which shows failure

 * animations fail on Safari

   update webkitTransform styles and set height to initial instead of 100%

 * make changes suggested by gkalpak

 * more fixes suggested by gkalpak

closes #3213, closes #3338, closes #3277, closes #3236, closes #3375
@topherfangio topherfangio force-pushed the wip/speed_dial_tooltips branch from d09952f to 78fcf18 Compare June 28, 2015 20:44
@ThomasBurleson
Copy link
Contributor

@topherfangio - nice work here. I also combined the Demos #2 & #3 while merging your PR.

@topherfangio topherfangio deleted the wip/speed_dial_tooltips branch June 29, 2015 21:22
@topherfangio
Copy link
Contributor Author

@ThomasBurleson Thanks so much! I was wondering myself if we should combine the demos, so I'm glad you did :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants