This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(backdrop, dialog, css): improve position and animations of backdrop #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robertmesserle - would you mind reviewing for inclusion in RC3 |
| if (position == 'static') { | ||
| // backdrop uses position:absolute and will not work properly with parent position:static (default) | ||
| var positionError = "<md-backdrop> may not work properly in a scrolled, static-positioned parent container."; | ||
| $log.warn( positionError ); |
ThomasBurleson
force-pushed
the
wip/backdrop_fixes
branch
from
7ae5b43
to
3e38550
Compare
improve backdrop animations and css to account for scroll and parenting: - backdrop - css uses transition and ng-enter/ng-leav - css transitions opacity instead of background-color - css no longer uses key frames - postLink uses $animate.pin if available - postLink logs a warning if the backdrop parent has a style 'position:static' - util - disableElementScroll uses specified element or body; used by dialog to disable dialog parent scrolling when parent is explicitly specified - refactor(util): centralize use of backdrop $compile - dialog - css for 'md-dialog-container' is now 'position:absolute'; 'fixed' is deprecated - hide backdrop now runs in parallel with hide dialog - basic demo #1 now uses element '#popupContainer' as parent; instead of document.body - basic demo #1 has #popupContainer 'position:relative' styling Fixes #3826, #3828, #1967, #1106
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve backdrop animations and css to account for scroll and parenting:
Fixes #3826, #3828, #1967, #1106