Fix md-menu animation timeout issues

[clshortfuse]

Fixes #3892

[ThomasBurleson]

@clshortfuse - The issue with the animation timeout is a conflict between ngAnimate and ngMaterial's animation solution. We are preparing a complete solution for all ngMaterial animation.

[clshortfuse]

Are you sure this won't fix? I understand you're restructuring the animation system, but right now now md-menu does not work at all on devices that take longer than 370ms to animate (pretty much all mobile devices).

I don't understand how this doesn't fix the issue.

When the timeout expires, it doesn't run the next piece of code because what equates to a single typo. It should call .finally instead of .then as it does with md-select.

Edit: Here's md-select's nearly identical implementation

https://github.com/angular/material/blob/master/src/components/select/select.js#L836

Edit2: Sorry if I'm being a bit pushy, but I was hoping I could have this committed, at least in the interim, so I don't have to keep using a forked version.

[stevenmiles]

@clshortfuse Interestingly enough, I has been suffering blocking with md-select in 0.10.1-rc2 until it was fixed in 0.10.rc3 171b7ed in the same way as you suggest for md-menu. Now I'm here as md-menu is broken.

@ThomasBurleson Seems you fixed the md-select locking, thank you. I'm guessing the animation solution won't be released in between a release candidate and a release. This would a good short term fix until the animation solution appears, as was the case for the md-select locking issue.

[KReden]

@ThomasBurleson Is there a time frame for this animation solution? If it is a ways off it might make sense to push a hotfix for this in the meantime, otherwise md-menu is pretty much broken on mobile and slower machines.

[ThomasBurleson]

@clshortfuse, @KReden, @stevenmiles - here is an interim fix to transitionEnd event timeouts [due to ngAnimate 1.4.x conflicts ]: ce46a9a

Btw, In our code base, using finally() is not a great solution for two (2) reasons:

• The finally() handler function is not passed the result or error from the promise reject/resolve.
• The finally() will not allow you to modify the value propagating. So rejections will continue to propagate.

[clshortfuse]

Thanks for the other fix! It makes much more sense to never reject. I was aware of the fact finally would have its issues only after, when I learned about the then(successCallback, errorCallback) option.

[ThomasBurleson]

@clshortfuse - 👍 , finally() is a tricky one.