Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

material-textarea #410

Closed
wants to merge 2 commits into from
Closed

material-textarea #410

wants to merge 2 commits into from

Conversation

andryfailli
Copy link

Hi,
This is my first contribution, a simple implementation of material-textarea.
There is a lot of code duplicated from material-input, maybe you have some idea to refactor.

We can also consider implementing an "auto-grow" feature. (I've tried https://github.com/monospaced/angular-elastic and it works like a charm)

@andryfailli andryfailli mentioned this pull request Oct 10, 2014
@ajoslin ajoslin force-pushed the master branch 2 times, most recently from 42c80f7 to 4c0c50e Compare October 16, 2014 13:38
@marcysutton
Copy link
Contributor

If we are to add a textarea component it will need a few things for accessibility:

  1. The textbox role
  2. It needs aria-multiline="true" to be a multiline component
  3. If it is disabled, aria-disabled="true"
  4. Keyboard events to submit depending on whether it is multiline

More information: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_textbox_role

Here is the relevant section of the Material Design spec: https://www.google.com/design/spec/components/text-fields.html#text-fields-multi-line-text-field

@marcysutton
Copy link
Contributor

Duplicate of #534.

@marcysutton marcysutton closed this Nov 6, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants