This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(mdChips): Fix error with audocomplete inside readonly chips and allow usage inside ng-repeat. #4133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topherfangio
added
the
pr: merge ready
|
@typotter ready for review :-) |
topherfangio
added
needs: work
and removed
pr: merge ready
topherfangio
force-pushed
the
chips-fix-2841
branch
2 times, most recently
from
0dbaf09
to
2ad43e3
Compare
…llow usage inside ng-repeat. When an autocomplete was used inside of mdChips with the readonly attribute set to true, it would throw an erroneous error that would cause the component to not be properly configured and thus stop working. Also, using <md-chips> inside of an ng-repeat would fail. Thanks to @robertmesserle for the guidance in getting this resolved. fixes #2841, fixes #3482
topherfangio
force-pushed
the
chips-fix-2841
branch
from
2ad43e3
to
d2da1c7
Compare
topherfangio
added
pr: merge ready
topherfangio
changed the title
|
LGTM |
|
lol, removed "erroneous" I guess it was a totally...roneous? error |
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this pull request
Sep 23, 2015
…llow usage inside ng-repeat. When an autocomplete was used inside of mdChips with the readonly attribute set to true, it would throw an erroneous error that would cause the component to not be properly configured and thus stop working. Also, using <md-chips> inside of an ng-repeat would fail. Thanks to @robertmesserle for the guidance in getting this resolved. fixes angular#2841, fixes angular#3482. closes angular#4133.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an autocomplete was used inside of mdChips with the readonly attribute set to true, it would throw an error that would cause the component to not be properly configured and thus stop working.
Also, using inside of an ng-repeat would fail. Thanks to
@robertmesserle for the guidance in getting this resolved.
fixes #2841, fixes #3482