Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

avoid pushing undefined chip to chips list #4194

Closed
wants to merge 1 commit into from
Closed

avoid pushing undefined chip to chips list #4194

wants to merge 1 commit into from

Conversation

emps
Copy link

@emps emps commented Aug 16, 2015

fix for #4193
undefined chip pushed into the items array while using md-on-append

ud

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@emps
Copy link
Author

emps commented Aug 16, 2015

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@emps emps closed this Aug 19, 2015
@topherfangio
Copy link
Contributor

@emps Hey, sorry we haven't had a chance to respond yet! Was there a particular reason you closed this PR? Was it fixed by something else?

I am actively working on the chips but took a short break to try to finish a few things for 0.11, so I haven't had time to review this yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants